Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-19 Thread Brendan Higgins
n Higgins > Cc: Benjamin Herrenschmidt ; Joel Stanley > ; Andrew Jeffery ; > linux-...@vger.kernel.org; OpenBMC Maillist ; Linux > ARM ; linux-asp...@lists.ozlabs.org; > Linux Kernel Mailing List ; > james.fe...@linux.intel.com; vernon.mau...@linux.intel.com; Benjamin Fair

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-19 Thread Brendan Higgins
n Higgins > Cc: Benjamin Herrenschmidt ; Joel Stanley > ; Andrew Jeffery ; > linux-...@vger.kernel.org; OpenBMC Maillist ; Linux > ARM ; linux-asp...@lists.ozlabs.org; > Linux Kernel Mailing List ; > james.fe...@linux.intel.com; vernon.mau...@linux.intel.com; Benjamin Fair

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-19 Thread Brendan Higgins
effery ; > > linux-...@vger.kernel.org; OpenBMC Maillist ; > > Linux ARM ; > > linux-asp...@lists.ozlabs.org; Linux Kernel Mailing List > > ; james.fe...@linux.intel.com; > > vernon.mau...@linux.intel.com; Benjamin Fair ; > > Patrick Venture ; Gary Hsu ;

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-19 Thread Brendan Higgins
effery ; > > linux-...@vger.kernel.org; OpenBMC Maillist ; > > Linux ARM ; > > linux-asp...@lists.ozlabs.org; Linux Kernel Mailing List > > ; james.fe...@linux.intel.com; > > vernon.mau...@linux.intel.com; Benjamin Fair ; > > Patrick Venture ; Gary Hsu ;

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-17 Thread Jae Hyun Yoo
driver to support multi-master use cases stably On 7/13/2018 11:12 AM, Brendan Higgins wrote: On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-17 Thread Jae Hyun Yoo
driver to support multi-master use cases stably On 7/13/2018 11:12 AM, Brendan Higgins wrote: On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote

RE: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-15 Thread Gary Hsu
; james.fe...@linux.intel.com; vernon.mau...@linux.intel.com; Benjamin Fair ; Patrick Venture ; Gary Hsu ; Ryan Chen Subject: Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably On 7/13/2018 11:12 AM, Brendan Higgins wrote: > On Fri, Jul 13, 2018 at 10:22 AM Jae H

RE: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-15 Thread Gary Hsu
; james.fe...@linux.intel.com; vernon.mau...@linux.intel.com; Benjamin Fair ; Patrick Venture ; Gary Hsu ; Ryan Chen Subject: Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably On 7/13/2018 11:12 AM, Brendan Higgins wrote: > On Fri, Jul 13, 2018 at 10:22 AM Jae H

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/13/2018 11:12 AM, Brendan Higgins wrote: On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: + for (;;) { + if

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/13/2018 11:12 AM, Brendan Higgins wrote: On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: + for (;;) { + if

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/13/2018 11:02 AM, Brendan Higgins wrote: On Thu, Jul 12, 2018 at 11:21 AM Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/13/2018 11:02 AM, Brendan Higgins wrote: On Thu, Jul 12, 2018 at 11:21 AM Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Brendan Higgins
On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: > > On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: > > On 7/12/2018 2:33 AM, Brendan Higgins wrote: > >> On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo > >> wrote: > >> > > + for (;;) { > > + if (!(readl(bus->base +

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Brendan Higgins
On Fri, Jul 13, 2018 at 10:22 AM Jae Hyun Yoo wrote: > > On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: > > On 7/12/2018 2:33 AM, Brendan Higgins wrote: > >> On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo > >> wrote: > >> > > + for (;;) { > > + if (!(readl(bus->base +

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Brendan Higgins
On Thu, Jul 12, 2018 at 11:21 AM Jae Hyun Yoo wrote: > > On 7/12/2018 2:33 AM, Brendan Higgins wrote: > > On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo > > wrote: > >> > > > +/* Timeout for bus busy checking */ > +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Brendan Higgins
On Thu, Jul 12, 2018 at 11:21 AM Jae Hyun Yoo wrote: > > On 7/12/2018 2:33 AM, Brendan Higgins wrote: > > On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo > > wrote: > >> > > > +/* Timeout for bus busy checking */ > +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ +#define BUS_BUSY_CHECK_INTERVAL

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-13 Thread Jae Hyun Yoo
On 7/12/2018 11:21 AM, Jae Hyun Yoo wrote: On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ +#define BUS_BUSY_CHECK_INTERVAL

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-12 Thread Jae Hyun Yoo
On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ +#define BUS_BUSY_CHECK_INTERVAL1 /* 10ms

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-12 Thread Jae Hyun Yoo
On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ +#define BUS_BUSY_CHECK_INTERVAL1 /* 10ms

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-12 Thread Brendan Higgins
On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: > > >> +/* Timeout for bus busy checking */ > >> +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ > >> +#define BUS_BUSY_CHECK_INTERVAL1 /* > >> 10ms */ > > > > Could you add a

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-12 Thread Brendan Higgins
On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: > > >> +/* Timeout for bus busy checking */ > >> +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ > >> +#define BUS_BUSY_CHECK_INTERVAL1 /* > >> 10ms */ > > > > Could you add a

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jae Hyun Yoo
Hi Jarkko, Thanks for the review. Please see my answer below. On 6/27/2018 12:48 AM, Jarkko Nikula wrote: Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jae Hyun Yoo
Hi Jarkko, Thanks for the review. Please see my answer below. On 6/27/2018 12:48 AM, Jarkko Nikula wrote: Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jae Hyun Yoo
Thanks Brendan for the review. Please see my answers inline. On 6/27/2018 12:36 AM, Brendan Higgins wrote: On Tue, Jun 26, 2018 at 9:58 AM Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jae Hyun Yoo
Thanks Brendan for the review. Please see my answers inline. On 6/27/2018 12:36 AM, Brendan Higgins wrote: On Tue, Jun 26, 2018 at 9:58 AM Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jarkko Nikula
Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jarkko Nikula
Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Brendan Higgins
On Tue, Jun 26, 2018 at 9:58 AM Jae Hyun Yoo wrote: > > BMC firmware should support some multi-master use cases such as multi-node, > IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit > unstable for the multi-master use case. So this patch improves ASPEED I2C > driver to

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Brendan Higgins
On Tue, Jun 26, 2018 at 9:58 AM Jae Hyun Yoo wrote: > > BMC firmware should support some multi-master use cases such as multi-node, > IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit > unstable for the multi-master use case. So this patch improves ASPEED I2C > driver to

[PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-26 Thread Jae Hyun Yoo
BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the multi-master use case stably. Changes: * Added

[PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-26 Thread Jae Hyun Yoo
BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the multi-master use case stably. Changes: * Added