Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-24 Thread Behan Webster
On 09/24/14 03:37, Arnd Bergmann wrote: On Tuesday 23 September 2014 12:25:31 beh...@converseincode.com wrote: #define DEFINE(sym, val) \ -asm volatile("\n->" #sym " %0 " #val : : "i" (val)) + asm volatile("\n@->" #sym " %0 " #val : : "i" (val)) Isn't the '@' character to start

Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-24 Thread Arnd Bergmann
On Tuesday 23 September 2014 12:25:31 beh...@converseincode.com wrote: > > #define DEFINE(sym, val) \ > -asm volatile("\n->" #sym " %0 " #val : : "i" (val)) > + asm volatile("\n@->" #sym " %0 " #val : : "i" (val)) Isn't the '@' character to start a comment architecture specific?

Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-24 Thread Arnd Bergmann
On Tuesday 23 September 2014 12:25:31 beh...@converseincode.com wrote: #define DEFINE(sym, val) \ -asm volatile(\n- #sym %0 #val : : i (val)) + asm volatile(\n@- #sym %0 #val : : i (val)) Isn't the '@' character to start a comment architecture specific? If this makes it

Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-24 Thread Behan Webster
On 09/24/14 03:37, Arnd Bergmann wrote: On Tuesday 23 September 2014 12:25:31 beh...@converseincode.com wrote: #define DEFINE(sym, val) \ -asm volatile(\n- #sym %0 #val : : i (val)) + asm volatile(\n@- #sym %0 #val : : i (val)) Isn't the '@' character to start a comment

[PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-23 Thread behanw
From: Behan Webster When using clang with -no-integerated-as clang will use the gnu assembler instead of the integrated assembler. However clang will still perform asm error checking before sending the inline assembly language to gas. The generation of asm-offsets from within C code is

[PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

2014-09-23 Thread behanw
From: Behan Webster beh...@converseincode.com When using clang with -no-integerated-as clang will use the gnu assembler instead of the integrated assembler. However clang will still perform asm error checking before sending the inline assembly language to gas. The generation of asm-offsets from