Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Paul E. McKenney
On Tue, May 08, 2018 at 05:49:25PM +0200, Anna-Maria Gleixner wrote: > On Tue, 8 May 2018, Paul E. McKenney wrote: > > > On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > > > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > > > > > On Fri, 4 May 2018, Paul E. McKenney wrote:

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Paul E. McKenney
On Tue, May 08, 2018 at 05:49:25PM +0200, Anna-Maria Gleixner wrote: > On Tue, 8 May 2018, Paul E. McKenney wrote: > > > On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > > > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > > > > > On Fri, 4 May 2018, Paul E. McKenney wrote:

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Anna-Maria Gleixner
On Tue, 8 May 2018, Paul E. McKenney wrote: > On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > > > On Fri, 4 May 2018, Paul E. McKenney wrote: > > > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > >

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Anna-Maria Gleixner
On Tue, 8 May 2018, Paul E. McKenney wrote: > On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > > > On Fri, 4 May 2018, Paul E. McKenney wrote: > > > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > >

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Paul E. McKenney
On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > On Fri, 4 May 2018, Paul E. McKenney wrote: > > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > > > (Me, I would run rcutorture scenario TREE03 for an

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Paul E. McKenney
On Tue, May 08, 2018 at 03:42:25PM +0200, Anna-Maria Gleixner wrote: > On Sat, 5 May 2018, Thomas Gleixner wrote: > > > On Fri, 4 May 2018, Paul E. McKenney wrote: > > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > > > (Me, I would run rcutorture scenario TREE03 for an

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Anna-Maria Gleixner
On Sat, 5 May 2018, Thomas Gleixner wrote: > On Fri, 4 May 2018, Paul E. McKenney wrote: > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > > (Me, I would run rcutorture scenario TREE03 for an extended time period > > > > on b4abf91047cf with your patch applied. > > > >

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-08 Thread Anna-Maria Gleixner
On Sat, 5 May 2018, Thomas Gleixner wrote: > On Fri, 4 May 2018, Paul E. McKenney wrote: > > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > > (Me, I would run rcutorture scenario TREE03 for an extended time period > > > > on b4abf91047cf with your patch applied. > > > >

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Thomas Gleixner
On Fri, 4 May 2018, Paul E. McKenney wrote: > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > (Me, I would run rcutorture scenario TREE03 for an extended time period > > > on b4abf91047cf with your patch applied. > > And with lockdep enabled, which TREE03 does not do by

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Thomas Gleixner
On Fri, 4 May 2018, Paul E. McKenney wrote: > On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > > > (Me, I would run rcutorture scenario TREE03 for an extended time period > > > on b4abf91047cf with your patch applied. > > And with lockdep enabled, which TREE03 does not do by

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Fri, May 04, 2018 at

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 11:38:37PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: > >> >> "Paul

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: >> "Paul E. McKenney" writes: >> >> > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: >> >> "Paul E. McKenney"

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: >> "Paul E. McKenney" writes: >> >> > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: >> >> "Paul E. McKenney" writes: >> >> >> >> > On Fri, May 04, 2018 at 12:17:20PM -0500,

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Fri, May 04, 2018 at

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 03:08:40PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: > >> >>

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: >> "Paul E. McKenney" writes: >> >> > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: >> >> Sebastian Andrzej Siewior

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: >> "Paul E. McKenney" writes: >> >> > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: >> >> Sebastian Andrzej Siewior writes: >> >> >> >> > On 2018-05-04 11:59:08 [-0500], Eric

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: > >> Sebastian Andrzej Siewior writes: > >> > >> > On 2018-05-04 11:59:08

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 02:03:04PM -0500, Eric W. Biederman wrote: > "Paul E. McKenney" writes: > > > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: > >> Sebastian Andrzej Siewior writes: > >> > >> > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: > >> >> Sebastian

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: >> Sebastian Andrzej Siewior writes: >> >> > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: >> >> Sebastian Andrzej Siewior

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: >> Sebastian Andrzej Siewior writes: >> >> > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: >> >> Sebastian Andrzej Siewior writes: >> >> > From: Anna-Maria Gleixner >> > … >> >> > This

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: > >> Sebastian Andrzej Siewior writes: > >> > From: Anna-Maria Gleixner

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Paul E. McKenney
On Fri, May 04, 2018 at 12:17:20PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: > >> Sebastian Andrzej Siewior writes: > >> > From: Anna-Maria Gleixner > > … > >> > This long-term fix has been made in commit

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: >> Sebastian Andrzej Siewior writes: >> > From: Anna-Maria Gleixner > … >> > This long-term fix has been made in commit

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: >> Sebastian Andrzej Siewior writes: >> > From: Anna-Maria Gleixner > … >> > This long-term fix has been made in commit 4abf91047cf ("rtmutex: Make > >> > wait_lock irq safe") for different reason. >>

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Sebastian Andrzej Siewior
On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > From: Anna-Maria Gleixner … > > This long-term fix has been made in commit 4abf91047cf ("rtmutex: Make > > > wait_lock irq safe") for different

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Sebastian Andrzej Siewior
On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > From: Anna-Maria Gleixner … > > This long-term fix has been made in commit 4abf91047cf ("rtmutex: Make > > > wait_lock irq safe") for different reason. > > Which tree has this change been made in?

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > From: Anna-Maria Gleixner > > Commit a841796f11c9 ("signal: align __lock_task_sighand() irq disabling and > RCU") introduced a rcu read side critical section with interrupts > disabled. The changelog suggested

Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > From: Anna-Maria Gleixner > > Commit a841796f11c9 ("signal: align __lock_task_sighand() irq disabling and > RCU") introduced a rcu read side critical section with interrupts > disabled. The changelog suggested that a better long-term fix would be "to > make

[PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Sebastian Andrzej Siewior
From: Anna-Maria Gleixner Commit a841796f11c9 ("signal: align __lock_task_sighand() irq disabling and RCU") introduced a rcu read side critical section with interrupts disabled. The changelog suggested that a better long-term fix would be "to make rt_mutex_unlock()

[PATCH] kernel/signal: Remove no longer required irqsave/restore

2018-05-04 Thread Sebastian Andrzej Siewior
From: Anna-Maria Gleixner Commit a841796f11c9 ("signal: align __lock_task_sighand() irq disabling and RCU") introduced a rcu read side critical section with interrupts disabled. The changelog suggested that a better long-term fix would be "to make rt_mutex_unlock() disable irqs when acquiring