Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-16 Thread Chen Gang
Oh, sorry for my original impolite reply (at least it is not quite gentle). :-) On 07/16/2013 08:22 AM, Chen Gang wrote: > On 07/16/2013 12:20 AM, Steven Rostedt wrote: >> On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: >> Hello Frederic and Ingo: >> Are you trying to go around me? I

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-16 Thread Chen Gang
Oh, sorry for my original impolite reply (at least it is not quite gentle). :-) On 07/16/2013 08:22 AM, Chen Gang wrote: On 07/16/2013 12:20 AM, Steven Rostedt wrote: On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: Hello Frederic and Ingo: Are you trying to go around me? I wrote this

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-15 Thread Chen Gang
On 07/16/2013 12:20 AM, Steven Rostedt wrote: > On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: > >> > Hello Frederic and Ingo: > Are you trying to go around me? I wrote this code and I'm one of the > maintainers for it. Your issue is very minor, and can wait till other > things get done

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-15 Thread Steven Rostedt
On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: > Hello Frederic and Ingo: Are you trying to go around me? I wrote this code and I'm one of the maintainers for it. Your issue is very minor, and can wait till other things get done first. You said my previous patch fixed your problem, right?

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-15 Thread Steven Rostedt
On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: Hello Frederic and Ingo: Are you trying to go around me? I wrote this code and I'm one of the maintainers for it. Your issue is very minor, and can wait till other things get done first. You said my previous patch fixed your problem, right?

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-15 Thread Chen Gang
On 07/16/2013 12:20 AM, Steven Rostedt wrote: On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote: Hello Frederic and Ingo: Are you trying to go around me? I wrote this code and I'm one of the maintainers for it. Your issue is very minor, and can wait till other things get done first.

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-14 Thread Chen Gang
On 07/12/2013 03:20 PM, Chen Gang wrote: > On 07/12/2013 11:04 AM, Chen Gang wrote: >> On 07/12/2013 10:38 AM, Steven Rostedt wrote: >>> On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: On 07/12/2013 09:41 AM, Steven Rostedt wrote: > On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote:

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-14 Thread Chen Gang
On 07/12/2013 03:20 PM, Chen Gang wrote: On 07/12/2013 11:04 AM, Chen Gang wrote: On 07/12/2013 10:38 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-12 Thread Chen Gang
On 07/12/2013 11:04 AM, Chen Gang wrote: > On 07/12/2013 10:38 AM, Steven Rostedt wrote: >> On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: >>> On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: >> Hmm, can all

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-12 Thread Chen Gang
On 07/12/2013 11:04 AM, Chen Gang wrote: On 07/12/2013 10:38 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all trace_selftest_startup_* (*selftest* in

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 10:38 AM, Steven Rostedt wrote: > On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: >> On 07/12/2013 09:41 AM, Steven Rostedt wrote: >>> On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: >>> > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) > use

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: > On 07/12/2013 09:41 AM, Steven Rostedt wrote: > > On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: > > > >> > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) > >> > use '__init', so not waste memory keeping them

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 09:41 AM, Steven Rostedt wrote: > On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: > >> > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) >> > use '__init', so not waste memory keeping them around ? > Yeah, they should all be set to __init, but that's

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) > use '__init', so not waste memory keeping them around ? Yeah, they should all be set to __init, but that's pretty low on the totem poll, as distros don't enable

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 12:47 AM, Steven Rostedt wrote: > On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote: >> Like other trace_selftest_startup_*, trace_selftest_startup_function() >> and trace_selftest_startup_function_graph() need in normal section, or >> may cause section mismatch. >> >> The related

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote: > Like other trace_selftest_startup_*, trace_selftest_startup_function() > and trace_selftest_startup_function_graph() need in normal section, or > may cause section mismatch. > > The related warnings: > > LD kernel/trace/built-in.o >

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote: Like other trace_selftest_startup_*, trace_selftest_startup_function() and trace_selftest_startup_function_graph() need in normal section, or may cause section mismatch. The related warnings: LD kernel/trace/built-in.o

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 12:47 AM, Steven Rostedt wrote: On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote: Like other trace_selftest_startup_*, trace_selftest_startup_function() and trace_selftest_startup_function_graph() need in normal section, or may cause section mismatch. The related warnings:

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) use '__init', so not waste memory keeping them around ? Yeah, they should all be set to __init, but that's pretty low on the totem poll, as distros don't enable selftests

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) use '__init', so not waste memory keeping them around ? Yeah, they should all be set to __init, but that's pretty low on

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Steven Rostedt
On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) use '__init', so not waste memory keeping them around ? Yeah,

Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-11 Thread Chen Gang
On 07/12/2013 10:38 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 09:58 +0800, Chen Gang wrote: On 07/12/2013 09:41 AM, Steven Rostedt wrote: On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote: Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c) use '__init', so not

[PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-10 Thread Chen Gang
Like other trace_selftest_startup_*, trace_selftest_startup_function() and trace_selftest_startup_function_graph() need in normal section, or may cause section mismatch. The related warnings: LD kernel/trace/built-in.o WARNING: kernel/trace/built-in.o(.data+0x154c): Section mismatch

[PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()

2013-07-10 Thread Chen Gang
Like other trace_selftest_startup_*, trace_selftest_startup_function() and trace_selftest_startup_function_graph() need in normal section, or may cause section mismatch. The related warnings: LD kernel/trace/built-in.o WARNING: kernel/trace/built-in.o(.data+0x154c): Section mismatch