Re: [PATCH] kthread: Spontaneous exit support

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 03:08:57PM +0200, Jan Engelhardt wrote: > >I don't think having to parallel APIs is a good idea, people will > >get utterly confused which one to use. Better always grab a reference > >in kthread_create and drop it in kthread_stop. For normal thread > >no change in

Re: [PATCH] kthread: Spontaneous exit support

2007-04-24 Thread Jan Engelhardt
On Apr 23 2007 12:25, Christoph Hellwig wrote: >On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: >> >> This patch implements the kthread helper functions kthread_start >> and kthread_end which make it simple to support a kernel thread >> that may decided to exit on it's own

Re: [PATCH] kthread: Spontaneous exit support

2007-04-24 Thread Jan Engelhardt
On Apr 23 2007 12:25, Christoph Hellwig wrote: On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may decided to exit on it's own before we

Re: [PATCH] kthread: Spontaneous exit support

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 03:08:57PM +0200, Jan Engelhardt wrote: I don't think having to parallel APIs is a good idea, people will get utterly confused which one to use. Better always grab a reference in kthread_create and drop it in kthread_stop. For normal thread no change in behaviour and

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Oleg Nesterov
On 04/23, Eric W. Biederman wrote: > > So I propose we add a kthread_orphan as a basic primitive to decrement the > count on the task_struct if we want a kthread to simply exit after it > has done some work. > > And as a helper function we can have a kthread_run_orphan. Speaking about helpers,

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Christoph Hellwig
On Mon, Apr 23, 2007 at 11:45:51AM -0600, Eric W. Biederman wrote: > Ok. Thinking about it I agree with Christoph that parallel API's can > be a problem. > > However we do still need to support kernel threads where kthread_stop will > never be called. There appear to be a few legitimate cases

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > On 04/23, Christoph Hellwig wrote: >> >> On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: >> > >> > This patch implements the kthread helper functions kthread_start >> > and kthread_end which make it simple to support a kernel thread

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Oleg Nesterov
On 04/23, Christoph Hellwig wrote: > > On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: > > > > This patch implements the kthread helper functions kthread_start > > and kthread_end which make it simple to support a kernel thread > > that may decided to exit on it's own before we

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Christoph Hellwig
On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: > > This patch implements the kthread helper functions kthread_start > and kthread_end which make it simple to support a kernel thread > that may decided to exit on it's own before we request it to. > It is still assumed that

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Christoph Hellwig
On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may decided to exit on it's own before we request it to. It is still assumed that

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Oleg Nesterov
On 04/23, Christoph Hellwig wrote: On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may decided to exit on it's own before we request

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: On 04/23, Christoph Hellwig wrote: On Sun, Apr 22, 2007 at 09:12:55PM -0600, Eric W. Biederman wrote: This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Christoph Hellwig
On Mon, Apr 23, 2007 at 11:45:51AM -0600, Eric W. Biederman wrote: Ok. Thinking about it I agree with Christoph that parallel API's can be a problem. However we do still need to support kernel threads where kthread_stop will never be called. There appear to be a few legitimate cases where

Re: [PATCH] kthread: Spontaneous exit support

2007-04-23 Thread Oleg Nesterov
On 04/23, Eric W. Biederman wrote: So I propose we add a kthread_orphan as a basic primitive to decrement the count on the task_struct if we want a kthread to simply exit after it has done some work. And as a helper function we can have a kthread_run_orphan. Speaking about helpers, could

[PATCH] kthread: Spontaneous exit support

2007-04-22 Thread Eric W. Biederman
This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may decided to exit on it's own before we request it to. It is still assumed that eventually we will get around to requesting that the kernel thread stop.

[PATCH] kthread: Spontaneous exit support

2007-04-22 Thread Eric W. Biederman
This patch implements the kthread helper functions kthread_start and kthread_end which make it simple to support a kernel thread that may decided to exit on it's own before we request it to. It is still assumed that eventually we will get around to requesting that the kernel thread stop.