Re: [PATCH] kunit: add unit test for filtering suites by names

2021-04-13 Thread Daniel Latypov
On Mon, Apr 12, 2021 at 10:00 PM David Gow wrote: > > On Tue, Apr 13, 2021 at 8:08 AM Daniel Latypov wrote: > > > > This adds unit tests for kunit_filter_subsuite() and > > kunit_filter_suites(). > > > > Note: what the executor means by "subsuite" is the array of suites > > corresponding to each

Re: [PATCH] kunit: add unit test for filtering suites by names

2021-04-13 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 1678e493d530e7977cce34e59a86bb86f3c5631e] url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-add-unit-test-for-filtering-suites-by-names/20210413-080913 base:

Re: [PATCH] kunit: add unit test for filtering suites by names

2021-04-12 Thread David Gow
On Tue, Apr 13, 2021 at 8:08 AM Daniel Latypov wrote: > > This adds unit tests for kunit_filter_subsuite() and > kunit_filter_suites(). > > Note: what the executor means by "subsuite" is the array of suites > corresponding to each test file. > > This patch lightly refactors executor.c to avoid

[PATCH] kunit: add unit test for filtering suites by names

2021-04-12 Thread Daniel Latypov
This adds unit tests for kunit_filter_subsuite() and kunit_filter_suites(). Note: what the executor means by "subsuite" is the array of suites corresponding to each test file. This patch lightly refactors executor.c to avoid the use of global variables to make it testable. It also includes a