Re: [PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-07 Thread Jacek Anaszewski
Hi Baolin and Geert, Geert - thanks for the heads-up. Baolin - thanks for the quick fix. Applied to the fixes-for-4.20-rc2 branch of linux-leds.git Best regards, Jacek Anaszewski On 11/07/2018 08:59 AM, Geert Uytterhoeven wrote: > Hi Baolin, > > On Wed, Nov 7, 2018 at 6:43 AM Baolin Wang

Re: [PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-07 Thread Jacek Anaszewski
Hi Baolin and Geert, Geert - thanks for the heads-up. Baolin - thanks for the quick fix. Applied to the fixes-for-4.20-rc2 branch of linux-leds.git Best regards, Jacek Anaszewski On 11/07/2018 08:59 AM, Geert Uytterhoeven wrote: > Hi Baolin, > > On Wed, Nov 7, 2018 at 6:43 AM Baolin Wang

Re: [PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-06 Thread Geert Uytterhoeven
Hi Baolin, On Wed, Nov 7, 2018 at 6:43 AM Baolin Wang wrote: > We will meet below issue due to mutex_lock() is called in interrupt context. > The mutex lock is used to protect the pattern trigger data, but before > changing > new pattern trigger data (pattern values or repeat value) by users,

Re: [PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-06 Thread Geert Uytterhoeven
Hi Baolin, On Wed, Nov 7, 2018 at 6:43 AM Baolin Wang wrote: > We will meet below issue due to mutex_lock() is called in interrupt context. > The mutex lock is used to protect the pattern trigger data, but before > changing > new pattern trigger data (pattern values or repeat value) by users,

[PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-06 Thread Baolin Wang
We will meet below issue due to mutex_lock() is called in interrupt context. The mutex lock is used to protect the pattern trigger data, but before changing new pattern trigger data (pattern values or repeat value) by users, we always cancel the timer firstly to clear previous patterns'

[PATCH] leds: trigger: Fix sleeping function called from invalid context

2018-11-06 Thread Baolin Wang
We will meet below issue due to mutex_lock() is called in interrupt context. The mutex lock is used to protect the pattern trigger data, but before changing new pattern trigger data (pattern values or repeat value) by users, we always cancel the timer firstly to clear previous patterns'