Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-26 Thread Tejun Heo
Hello, Vladimir. On Wed, Jul 26, 2017 at 11:30:17AM +0300, Vladimir Davydov wrote: > > As I understand, css_reset() callback is intended to _completely_ disable > > all > > limits, as if there were no cgroup at all. > > But that's exactly what cgroup offline is: deletion of a cgroup as if it >

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-26 Thread Tejun Heo
Hello, Vladimir. On Wed, Jul 26, 2017 at 11:30:17AM +0300, Vladimir Davydov wrote: > > As I understand, css_reset() callback is intended to _completely_ disable > > all > > limits, as if there were no cgroup at all. > > But that's exactly what cgroup offline is: deletion of a cgroup as if it >

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-26 Thread Vladimir Davydov
On Tue, Jul 25, 2017 at 01:31:13PM +0100, Roman Gushchin wrote: > On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > > A removed memory cgroup with a defined low limit and some belonging > > > pagecache has very

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-26 Thread Vladimir Davydov
On Tue, Jul 25, 2017 at 01:31:13PM +0100, Roman Gushchin wrote: > On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > > A removed memory cgroup with a defined low limit and some belonging > > > pagecache has very

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 13:31:13, Roman Gushchin wrote: > On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > > A removed memory cgroup with a defined low limit and some belonging > > > pagecache has very low chances to

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 13:31:13, Roman Gushchin wrote: > On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > > A removed memory cgroup with a defined low limit and some belonging > > > pagecache has very low chances to

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > A removed memory cgroup with a defined low limit and some belonging > > pagecache has very low chances to be freed. > > > > If a cgroup has been removed, there

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
On Tue, Jul 25, 2017 at 03:05:37PM +0300, Vladimir Davydov wrote: > On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > > A removed memory cgroup with a defined low limit and some belonging > > pagecache has very low chances to be freed. > > > > If a cgroup has been removed, there

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
On Tue, Jul 25, 2017 at 01:58:08PM +0200, Michal Hocko wrote: > On Tue 25-07-17 12:40:47, Roman Gushchin wrote: > > A removed memory cgroup with a defined low limit and some belonging > > pagecache has very low chances to be freed. > > > > If a cgroup has been removed, there is likely no memory

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
On Tue, Jul 25, 2017 at 01:58:08PM +0200, Michal Hocko wrote: > On Tue 25-07-17 12:40:47, Roman Gushchin wrote: > > A removed memory cgroup with a defined low limit and some belonging > > pagecache has very low chances to be freed. > > > > If a cgroup has been removed, there is likely no memory

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Vladimir Davydov
On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > A removed memory cgroup with a defined low limit and some belonging > pagecache has very low chances to be freed. > > If a cgroup has been removed, there is likely no memory pressure inside > the cgroup, and the pagecache is

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Vladimir Davydov
On Tue, Jul 25, 2017 at 12:40:47PM +0100, Roman Gushchin wrote: > A removed memory cgroup with a defined low limit and some belonging > pagecache has very low chances to be freed. > > If a cgroup has been removed, there is likely no memory pressure inside > the cgroup, and the pagecache is

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 12:40:47, Roman Gushchin wrote: > A removed memory cgroup with a defined low limit and some belonging > pagecache has very low chances to be freed. > > If a cgroup has been removed, there is likely no memory pressure inside > the cgroup, and the pagecache is protected from the

Re: [PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 12:40:47, Roman Gushchin wrote: > A removed memory cgroup with a defined low limit and some belonging > pagecache has very low chances to be freed. > > If a cgroup has been removed, there is likely no memory pressure inside > the cgroup, and the pagecache is protected from the

[PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
A removed memory cgroup with a defined low limit and some belonging pagecache has very low chances to be freed. If a cgroup has been removed, there is likely no memory pressure inside the cgroup, and the pagecache is protected from the external pressure by the defined low limit. The cgroup will

[PATCH] mm, memcg: reset low limit during memcg offlining

2017-07-25 Thread Roman Gushchin
A removed memory cgroup with a defined low limit and some belonging pagecache has very low chances to be freed. If a cgroup has been removed, there is likely no memory pressure inside the cgroup, and the pagecache is protected from the external pressure by the defined low limit. The cgroup will