Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-16 Thread Waiman Long
On 06/12/2014 05:45 PM, David Rientjes wrote: On Thu, 12 Jun 2014, Waiman Long wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-16 Thread Waiman Long
On 06/12/2014 05:45 PM, David Rientjes wrote: On Thu, 12 Jun 2014, Waiman Long wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread David Rientjes
On Thu, 12 Jun 2014, Waiman Long wrote: > > > The vma_address() function which is used to compute the virtual address > > > within a VMA is used only by 2 files in the mm subsystem - rmap.c and > > > huge_memory.c. This function is defined in rmap.c and is inlined by > > > its callers there, but

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Waiman Long
On 06/12/2014 03:25 PM, Andrew Morton wrote: On Thu, 12 Jun 2014 15:15:40 -0400 Waiman Long wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Andrew Morton
On Thu, 12 Jun 2014 15:15:40 -0400 Waiman Long wrote: > The vma_address() function which is used to compute the virtual address > within a VMA is used only by 2 files in the mm subsystem - rmap.c and > huge_memory.c. This function is defined in rmap.c and is inlined by > its callers there, but

[PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Waiman Long
The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined by its callers there, but it is also declared as an external function. However, the

[PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Waiman Long
The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined by its callers there, but it is also declared as an external function. However, the

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Andrew Morton
On Thu, 12 Jun 2014 15:15:40 -0400 Waiman Long waiman.l...@hp.com wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined by its

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread Waiman Long
On 06/12/2014 03:25 PM, Andrew Morton wrote: On Thu, 12 Jun 2014 15:15:40 -0400 Waiman Longwaiman.l...@hp.com wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is

Re: [PATCH] mm: Move __vma_address() to internal.h to be inlined in huge_memory.c

2014-06-12 Thread David Rientjes
On Thu, 12 Jun 2014, Waiman Long wrote: The vma_address() function which is used to compute the virtual address within a VMA is used only by 2 files in the mm subsystem - rmap.c and huge_memory.c. This function is defined in rmap.c and is inlined by its callers there, but it is also