Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-06 Thread Sasha Levin
On 03/06/2014 11:08 AM, Naoya Horiguchi wrote: > And I found my patch was totally wrong because it should check > !pte_present(), not pte_present(). > I'm testing fixed one (see below), and the problem seems not to reproduce > in my environment at least for now. > But I'm not 100% sure, so I need

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-06 Thread Sasha Levin
On 03/06/2014 11:08 AM, Naoya Horiguchi wrote: And I found my patch was totally wrong because it should check !pte_present(), not pte_present(). I'm testing fixed one (see below), and the problem seems not to reproduce in my environment at least for now. But I'm not 100% sure, so I need your

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-05 Thread Sasha Levin
On 03/04/2014 06:49 PM, Naoya Horiguchi wrote: > On Tue, Mar 04, 2014 at 05:46:52PM -0500, Sasha Levin wrote: >> On 03/04/2014 04:32 PM, Naoya Horiguchi wrote: >>> # sorry if duplicate message >>> >>> On Mon, Mar 03, 2014 at 04:38:41PM -0500, Sasha Levin wrote: On 03/03/2014 03:06 PM, Sasha

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-05 Thread Sasha Levin
On 03/04/2014 06:49 PM, Naoya Horiguchi wrote: On Tue, Mar 04, 2014 at 05:46:52PM -0500, Sasha Levin wrote: On 03/04/2014 04:32 PM, Naoya Horiguchi wrote: # sorry if duplicate message On Mon, Mar 03, 2014 at 04:38:41PM -0500, Sasha Levin wrote: On 03/03/2014 03:06 PM, Sasha Levin wrote: On

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-04 Thread Sasha Levin
On 03/04/2014 04:32 PM, Naoya Horiguchi wrote: > # sorry if duplicate message > > On Mon, Mar 03, 2014 at 04:38:41PM -0500, Sasha Levin wrote: >> On 03/03/2014 03:06 PM, Sasha Levin wrote: >>> On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, >> I can confirm that with this

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-04 Thread Sasha Levin
On 03/04/2014 04:32 PM, Naoya Horiguchi wrote: # sorry if duplicate message On Mon, Mar 03, 2014 at 04:38:41PM -0500, Sasha Levin wrote: On 03/03/2014 03:06 PM, Sasha Levin wrote: On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, I can confirm that with this patch the lockdep issue

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-03 Thread Sasha Levin
On 03/03/2014 03:06 PM, Sasha Levin wrote: On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, >I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in >walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem.

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-03 Thread Sasha Levin
On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, >I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in >walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem. Could you try testing if this patch fixes

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-03 Thread Sasha Levin
On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem. Could you try testing if this patch fixes it?

Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-03 Thread Sasha Levin
On 03/03/2014 03:06 PM, Sasha Levin wrote: On 03/03/2014 12:02 AM, Naoya Horiguchi wrote: Hi Sasha, I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem.

[PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-02 Thread Naoya Horiguchi
Hi Sasha, > I can confirm that with this patch the lockdep issue is gone. However, the > NULL deref in > walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem. Could you try testing if this patch fixes it? Thanks, Naoya --- Page table walker

[PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks

2014-03-02 Thread Naoya Horiguchi
Hi Sasha, I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear. I spotted the cause of this problem. Could you try testing if this patch fixes it? Thanks, Naoya --- Page table walker doesn't