Re: [PATCH] mm: clean up soft_offline_page()

2012-12-14 Thread Naoya Horiguchi
Hi Xishi, On Fri, Dec 14, 2012 at 11:06:56AM +0800, Xishi Qiu wrote: > On 2012/12/14 7:01, Naoya Horiguchi wrote: ... > > + ret = get_any_page(page, pfn, flags); > > + if (ret < 0) > > + return ret; > > + if (ret) { /* for in-use pages */ > > + if (PageHuge(page)) > > +

Re: [PATCH] mm: clean up soft_offline_page()

2012-12-14 Thread Naoya Horiguchi
Hi Xishi, On Fri, Dec 14, 2012 at 11:06:56AM +0800, Xishi Qiu wrote: On 2012/12/14 7:01, Naoya Horiguchi wrote: ... + ret = get_any_page(page, pfn, flags); + if (ret 0) + return ret; + if (ret) { /* for in-use pages */ + if (PageHuge(page)) +

Re: [PATCH] mm: clean up soft_offline_page()

2012-12-13 Thread Xishi Qiu
so with this patch we can deal with the > problem. > > Thanks, > Naoya > --- > From: Naoya Horiguchi > Date: Thu, 13 Dec 2012 16:08:54 -0500 > Subject: [PATCH] mm: clean up soft_offline_page() > > Currently soft_offline_page() is hard to maintain because it h

[PATCH] mm: clean up soft_offline_page()

2012-12-13 Thread Naoya Horiguchi
: Naoya Horiguchi Date: Thu, 13 Dec 2012 16:08:54 -0500 Subject: [PATCH] mm: clean up soft_offline_page() Currently soft_offline_page() is hard to maintain because it has many return points and goto statements. All of this mess come from get_any_page(). This function should only get page refcount

[PATCH] mm: clean up soft_offline_page()

2012-12-13 Thread Naoya Horiguchi
: Naoya Horiguchi n-horigu...@ah.jp.nec.com Date: Thu, 13 Dec 2012 16:08:54 -0500 Subject: [PATCH] mm: clean up soft_offline_page() Currently soft_offline_page() is hard to maintain because it has many return points and goto statements. All of this mess come from get_any_page(). This function should

Re: [PATCH] mm: clean up soft_offline_page()

2012-12-13 Thread Xishi Qiu
can deal with the problem. Thanks, Naoya --- From: Naoya Horiguchi n-horigu...@ah.jp.nec.com Date: Thu, 13 Dec 2012 16:08:54 -0500 Subject: [PATCH] mm: clean up soft_offline_page() Currently soft_offline_page() is hard to maintain because it has many return points and goto statements