Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-12 Thread Michal Hocko
On Fri 12-01-18 13:41:33, Sergey Senozhatsky wrote: > On (01/08/18 19:22), Sergey Senozhatsky wrote: > [..] > > > Your changelog is rather modest on the information. > > > > fair point! > > > > > Could you be more specific on how the problem actually happens how > > > likely it is? > > > > ok.

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-12 Thread Michal Hocko
On Fri 12-01-18 13:41:33, Sergey Senozhatsky wrote: > On (01/08/18 19:22), Sergey Senozhatsky wrote: > [..] > > > Your changelog is rather modest on the information. > > > > fair point! > > > > > Could you be more specific on how the problem actually happens how > > > likely it is? > > > > ok.

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-11 Thread Sergey Senozhatsky
On (01/08/18 19:22), Sergey Senozhatsky wrote: [..] > > Your changelog is rather modest on the information. > > fair point! > > > Could you be more specific on how the problem actually happens how > > likely it is? > > ok. so what we have is > > slow_path / swap-out page >

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-11 Thread Sergey Senozhatsky
On (01/08/18 19:22), Sergey Senozhatsky wrote: [..] > > Your changelog is rather modest on the information. > > fair point! > > > Could you be more specific on how the problem actually happens how > > likely it is? > > ok. so what we have is > > slow_path / swap-out page >

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-08 Thread Sergey Senozhatsky
On (01/08/18 09:37), Michal Hocko wrote: [..] > > the lockup is not the main problem and I'm not really trying to > > address it here. we simply can fill up the entire kernel logbuf > > with the same "Write-error on swap-device" errors. > > Your changelog is rather modest on the information.

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-08 Thread Sergey Senozhatsky
On (01/08/18 09:37), Michal Hocko wrote: [..] > > the lockup is not the main problem and I'm not really trying to > > address it here. we simply can fill up the entire kernel logbuf > > with the same "Write-error on swap-device" errors. > > Your changelog is rather modest on the information.

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-08 Thread Michal Hocko
On Mon 08-01-18 10:58:18, Sergey Senozhatsky wrote: > On (01/06/18 14:34), Michal Hocko wrote: > > > zsmalloc allocation is just one possibility; an error in > > > compressing algorithm is another one, yet is rather unlikely. > > > most likely it's OOM which can cause problems. but in any case > >

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-08 Thread Michal Hocko
On Mon 08-01-18 10:58:18, Sergey Senozhatsky wrote: > On (01/06/18 14:34), Michal Hocko wrote: > > > zsmalloc allocation is just one possibility; an error in > > > compressing algorithm is another one, yet is rather unlikely. > > > most likely it's OOM which can cause problems. but in any case > >

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-07 Thread Sergey Senozhatsky
On (01/06/18 14:34), Michal Hocko wrote: > > zsmalloc allocation is just one possibility; an error in > > compressing algorithm is another one, yet is rather unlikely. > > most likely it's OOM which can cause problems. but in any case > > it's sort of unclear what should be done. an error can be a

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-07 Thread Sergey Senozhatsky
On (01/06/18 14:34), Michal Hocko wrote: > > zsmalloc allocation is just one possibility; an error in > > compressing algorithm is another one, yet is rather unlikely. > > most likely it's OOM which can cause problems. but in any case > > it's sort of unclear what should be done. an error can be a

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Michal Hocko
On Sat 06-01-18 19:03:13, Sergey Senozhatsky wrote: > Hello, > > On (01/06/18 10:41), Michal Hocko wrote: > > On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > > > Use the ratelimited printk() version for swap-device write error > > > reporting. We can use ZRAM as a swap-device, and the

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Michal Hocko
On Sat 06-01-18 19:03:13, Sergey Senozhatsky wrote: > Hello, > > On (01/06/18 10:41), Michal Hocko wrote: > > On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > > > Use the ratelimited printk() version for swap-device write error > > > reporting. We can use ZRAM as a swap-device, and the

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Sergey Senozhatsky
Hello, On (01/06/18 10:41), Michal Hocko wrote: > On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > > Use the ratelimited printk() version for swap-device write error > > reporting. We can use ZRAM as a swap-device, and the tricky part > > here is that zsmalloc() stores compressed objects in

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Sergey Senozhatsky
Hello, On (01/06/18 10:41), Michal Hocko wrote: > On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > > Use the ratelimited printk() version for swap-device write error > > reporting. We can use ZRAM as a swap-device, and the tricky part > > here is that zsmalloc() stores compressed objects in

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Michal Hocko
On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > Use the ratelimited printk() version for swap-device write error > reporting. We can use ZRAM as a swap-device, and the tricky part > here is that zsmalloc() stores compressed objects in memory, thus > it has to allocates pages during swap-out.

Re: [PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-06 Thread Michal Hocko
On Sat 06-01-18 13:34:07, Sergey Senozhatsky wrote: > Use the ratelimited printk() version for swap-device write error > reporting. We can use ZRAM as a swap-device, and the tricky part > here is that zsmalloc() stores compressed objects in memory, thus > it has to allocates pages during swap-out.

[PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-05 Thread Sergey Senozhatsky
Use the ratelimited printk() version for swap-device write error reporting. We can use ZRAM as a swap-device, and the tricky part here is that zsmalloc() stores compressed objects in memory, thus it has to allocates pages during swap-out. If the system is short on memory, then we begin to flood

[PATCH] mm: ratelimit end_swap_bio_write() error

2018-01-05 Thread Sergey Senozhatsky
Use the ratelimited printk() version for swap-device write error reporting. We can use ZRAM as a swap-device, and the tricky part here is that zsmalloc() stores compressed objects in memory, thus it has to allocates pages during swap-out. If the system is short on memory, then we begin to flood