Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-05-07 Thread David Rientjes
On Tue, 21 Jan 2014, David Rientjes wrote: > On Wed, 8 Jan 2014, David Rientjes wrote: > > > > There used to be only one path out of __slab_alloc(), and > > > ALLOC_SLOWPATH got bumped in that exit path. Now there are two, > > > and a bunch of gotos. ALLOC_SLOWPATH can now get set more than

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-05-07 Thread David Rientjes
On Tue, 21 Jan 2014, David Rientjes wrote: On Wed, 8 Jan 2014, David Rientjes wrote: There used to be only one path out of __slab_alloc(), and ALLOC_SLOWPATH got bumped in that exit path. Now there are two, and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-21 Thread David Rientjes
On Wed, 8 Jan 2014, David Rientjes wrote: > > There used to be only one path out of __slab_alloc(), and > > ALLOC_SLOWPATH got bumped in that exit path. Now there are two, > > and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once > > during a single call to __slab_alloc() which is

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-21 Thread David Rientjes
On Wed, 8 Jan 2014, David Rientjes wrote: There used to be only one path out of __slab_alloc(), and ALLOC_SLOWPATH got bumped in that exit path. Now there are two, and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once during a single call to __slab_alloc() which is pretty

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-08 Thread David Rientjes
On Mon, 6 Jan 2014, Dave Hansen wrote: > There used to be only one path out of __slab_alloc(), and > ALLOC_SLOWPATH got bumped in that exit path. Now there are two, > and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once > during a single call to __slab_alloc() which is pretty

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-08 Thread David Rientjes
On Mon, 6 Jan 2014, Dave Hansen wrote: There used to be only one path out of __slab_alloc(), and ALLOC_SLOWPATH got bumped in that exit path. Now there are two, and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once during a single call to __slab_alloc() which is pretty bogus.

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-06 Thread Christoph Lameter
On Mon, 6 Jan 2014, Dave Hansen wrote: > This patch moves stat(s, ALLOC_SLOWPATH) to be called from the > same place that __slab_alloc() is. This makes it much less > likely that ALLOC_SLOWPATH will get botched again in the > spaghetti-code inside __slab_alloc(). Acked-by: Christoph Lameter

[PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-06 Thread Dave Hansen
From: Dave Hansen There used to be only one path out of __slab_alloc(), and ALLOC_SLOWPATH got bumped in that exit path. Now there are two, and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once during a single call to __slab_alloc() which is pretty bogus. Here's the sequence:

[PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-06 Thread Dave Hansen
From: Dave Hansen dave.han...@linux.intel.com There used to be only one path out of __slab_alloc(), and ALLOC_SLOWPATH got bumped in that exit path. Now there are two, and a bunch of gotos. ALLOC_SLOWPATH can now get set more than once during a single call to __slab_alloc() which is pretty

Re: [PATCH] mm: slub: fix ALLOC_SLOWPATH stat

2014-01-06 Thread Christoph Lameter
On Mon, 6 Jan 2014, Dave Hansen wrote: This patch moves stat(s, ALLOC_SLOWPATH) to be called from the same place that __slab_alloc() is. This makes it much less likely that ALLOC_SLOWPATH will get botched again in the spaghetti-code inside __slab_alloc(). Acked-by: Christoph Lameter