Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Sat, Jan 05, 2013 at 06:24:47AM -0600, Simon Jeons wrote: > On Fri, 2013-01-04 at 17:32 -0800, Michel Lespinasse wrote: > > On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman wrote: > > > Despite the reason for these commits, NUMA balancing is not the direct > > > source of the problem.

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Fri, Jan 04, 2013 at 05:32:17PM -0800, Michel Lespinasse wrote: > On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman wrote: > > Despite the reason for these commits, NUMA balancing is not the direct > > source of the problem. split_huge_page() expected the anon_vma lock to be > > exclusive to

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Sat, Jan 05, 2013 at 01:51:09PM +0800, Zhouping Liu wrote: > On 01/04/2013 10:08 PM, Mel Gorman wrote: > >Zhouping, please test this patch. > > Tested it, the issue is gone with following patch. > > Tested-by: Zhouping Liu > Super. Thanks very much for reporting and testing this quickly.

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Fri, Jan 04, 2013 at 01:28:09PM -0800, Hugh Dickins wrote: > I've added Alexander, Hillf and Alex to the Cc. > > On Fri, 4 Jan 2013, Mel Gorman wrote: > > Zhouping, please test this patch. > > > > Andrea and Hugh, any comments on whether this could be improved? > > Your patch itself looks

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Fri, Jan 04, 2013 at 01:28:09PM -0800, Hugh Dickins wrote: I've added Alexander, Hillf and Alex to the Cc. On Fri, 4 Jan 2013, Mel Gorman wrote: Zhouping, please test this patch. Andrea and Hugh, any comments on whether this could be improved? Your patch itself looks just right to

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Sat, Jan 05, 2013 at 01:51:09PM +0800, Zhouping Liu wrote: On 01/04/2013 10:08 PM, Mel Gorman wrote: Zhouping, please test this patch. Tested it, the issue is gone with following patch. Tested-by: Zhouping Liu z...@redhat.com Super. Thanks very much for reporting and testing this

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Fri, Jan 04, 2013 at 05:32:17PM -0800, Michel Lespinasse wrote: On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman mgor...@suse.de wrote: Despite the reason for these commits, NUMA balancing is not the direct source of the problem. split_huge_page() expected the anon_vma lock to be exclusive to

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-07 Thread Mel Gorman
On Sat, Jan 05, 2013 at 06:24:47AM -0600, Simon Jeons wrote: On Fri, 2013-01-04 at 17:32 -0800, Michel Lespinasse wrote: On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman mgor...@suse.de wrote: Despite the reason for these commits, NUMA balancing is not the direct source of the problem.

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-05 Thread Simon Jeons
On Fri, 2013-01-04 at 17:32 -0800, Michel Lespinasse wrote: > On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman wrote: > > Despite the reason for these commits, NUMA balancing is not the direct > > source of the problem. split_huge_page() expected the anon_vma lock to be > > exclusive to serialise the

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-05 Thread Simon Jeons
On Fri, 2013-01-04 at 14:08 +, Mel Gorman wrote: > Zhouping, please test this patch. > > Andrea and Hugh, any comments on whether this could be improved? > > ---8<--- > mm: thp: Acquire the anon_vma rwsem for lock during split > > Zhouping Liu reported the following against 3.8-rc1 when

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-05 Thread Simon Jeons
On Fri, 2013-01-04 at 14:08 +, Mel Gorman wrote: Zhouping, please test this patch. Andrea and Hugh, any comments on whether this could be improved? ---8--- mm: thp: Acquire the anon_vma rwsem for lock during split Zhouping Liu reported the following against 3.8-rc1 when running a

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-05 Thread Simon Jeons
On Fri, 2013-01-04 at 17:32 -0800, Michel Lespinasse wrote: On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman mgor...@suse.de wrote: Despite the reason for these commits, NUMA balancing is not the direct source of the problem. split_huge_page() expected the anon_vma lock to be exclusive to

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Zhouping Liu
On 01/04/2013 10:08 PM, Mel Gorman wrote: Zhouping, please test this patch. Tested it, the issue is gone with following patch. Tested-by: Zhouping Liu Thanks, Zhouping Andrea and Hugh, any comments on whether this could be improved? ---8<--- mm: thp: Acquire the anon_vma rwsem for lock

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Michel Lespinasse
On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman wrote: > Despite the reason for these commits, NUMA balancing is not the direct > source of the problem. split_huge_page() expected the anon_vma lock to be > exclusive to serialise the whole split operation. Ordinarily it is expected > that the anon_vma

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Hugh Dickins
I've added Alexander, Hillf and Alex to the Cc. On Fri, 4 Jan 2013, Mel Gorman wrote: > Zhouping, please test this patch. > > Andrea and Hugh, any comments on whether this could be improved? Your patch itself looks just right to me, no improvement required; and it's easy to understand how the

[PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Mel Gorman
Zhouping, please test this patch. Andrea and Hugh, any comments on whether this could be improved? ---8<--- mm: thp: Acquire the anon_vma rwsem for lock during split Zhouping Liu reported the following against 3.8-rc1 when running a mmap testcase from LTP. [ 588.143072] mapcount 0

[PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Mel Gorman
Zhouping, please test this patch. Andrea and Hugh, any comments on whether this could be improved? ---8--- mm: thp: Acquire the anon_vma rwsem for lock during split Zhouping Liu reported the following against 3.8-rc1 when running a mmap testcase from LTP. [ 588.143072] mapcount 0

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Hugh Dickins
I've added Alexander, Hillf and Alex to the Cc. On Fri, 4 Jan 2013, Mel Gorman wrote: Zhouping, please test this patch. Andrea and Hugh, any comments on whether this could be improved? Your patch itself looks just right to me, no improvement required; and it's easy to understand how the bug

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Michel Lespinasse
On Fri, Jan 4, 2013 at 6:08 AM, Mel Gorman mgor...@suse.de wrote: Despite the reason for these commits, NUMA balancing is not the direct source of the problem. split_huge_page() expected the anon_vma lock to be exclusive to serialise the whole split operation. Ordinarily it is expected that

Re: [PATCH] mm: thp: Acquire the anon_vma rwsem for lock during split

2013-01-04 Thread Zhouping Liu
On 01/04/2013 10:08 PM, Mel Gorman wrote: Zhouping, please test this patch. Tested it, the issue is gone with following patch. Tested-by: Zhouping Liu z...@redhat.com Thanks, Zhouping Andrea and Hugh, any comments on whether this could be improved? ---8--- mm: thp: Acquire the anon_vma