Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-08-02 Thread Ulf Hansson
On Mon, 29 Jul 2019 at 02:01, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap': > drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-08-01 Thread Ludovic Desroches
On Wed, Jul 31, 2019 at 09:06:07AM -0700, Kees Cook wrote: > On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > >host->caps.need_notbusy_for_read_ops = 1; >

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-31 Thread Kees Cook
On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall > > through [-Wimplicit-fallthrough=] > >host->caps.need_notbusy_for_read_ops = 1; > >~^~~ > >

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-31 Thread Ludovic Desroches
Hi, On Sun, Jul 28, 2019 at 07:01:23PM -0500, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap': > drivers/mmc/host/atmel-mci.c:2415:30: warning:

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-29 Thread Kees Cook
On Sun, Jul 28, 2019 at 07:01:23PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap': > drivers/mmc/host/atmel-mci.c:2415:30: warning: this

[PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-28 Thread Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap': drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may fall through [-Wimplicit-fallthrough=] host->caps.has_odd_clk_div =