Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-27 Thread Ulf Hansson
On 14 October 2014 18:33, Doug Anderson wrote: > The dw_mmc driver had a bunch of code that ran whenever a card was > ejected and inserted. However, this code was old and crufty and > should be removed. Some evidence that it's really not needed: > > 1. Is is supposed to be legal to use

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-27 Thread Ulf Hansson
On 14 October 2014 18:33, Doug Anderson diand...@chromium.org wrote: The dw_mmc driver had a bunch of code that ran whenever a card was ejected and inserted. However, this code was old and crufty and should be removed. Some evidence that it's really not needed: 1. Is is supposed to be legal

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-23 Thread Alim Akhtar
Hi Doug, On Wed, Oct 22, 2014 at 10:06 PM, Doug Anderson wrote: > Hi, > > On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung wrote: >> Hi. >> >> On 10/17/2014 09:44 PM, Alim Akhtar wrote: >>> Hi Doug, >>> >>> On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson >>> wrote: Alim, On Thu,

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-23 Thread Alim Akhtar
Hi Doug, On Wed, Oct 22, 2014 at 10:06 PM, Doug Anderson diand...@chromium.org wrote: Hi, On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi. On 10/17/2014 09:44 PM, Alim Akhtar wrote: Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-22 Thread Jaehoon Chung
Dear, Doug. On 10/23/2014 01:36 AM, Doug Anderson wrote: > Hi, > > On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung wrote: >> Hi. >> >> On 10/17/2014 09:44 PM, Alim Akhtar wrote: >>> Hi Doug, >>> >>> On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson >>> wrote: Alim, On Thu, Oct 16,

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-22 Thread Doug Anderson
Hi, On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung wrote: > Hi. > > On 10/17/2014 09:44 PM, Alim Akhtar wrote: >> Hi Doug, >> >> On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson wrote: >>> Alim, >>> >>> On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar wrote: Hi Doug, On Tue, Oct 14,

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-22 Thread Jaehoon Chung
Dear, Doug. On 10/23/2014 01:36 AM, Doug Anderson wrote: Hi, On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi. On 10/17/2014 09:44 PM, Alim Akhtar wrote: Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson diand...@chromium.org wrote: Alim, On

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-22 Thread Doug Anderson
Hi, On Sun, Oct 19, 2014 at 8:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi. On 10/17/2014 09:44 PM, Alim Akhtar wrote: Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson diand...@chromium.org wrote: Alim, On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar alim.akh...@gmail.com

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-19 Thread Jaehoon Chung
Hi. On 10/17/2014 09:44 PM, Alim Akhtar wrote: > Hi Doug, > > On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson wrote: >> Alim, >> >> On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar wrote: >>> Hi Doug, >>> >>> On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson >>> wrote: The dw_mmc driver had a

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-19 Thread Jaehoon Chung
Hi. On 10/17/2014 09:44 PM, Alim Akhtar wrote: Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson diand...@chromium.org wrote: Alim, On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Doug, On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-17 Thread Alim Akhtar
Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson wrote: > Alim, > > On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar wrote: >> Hi Doug, >> >> On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson >> wrote: >>> The dw_mmc driver had a bunch of code that ran whenever a card was >>> ejected and

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-17 Thread Alim Akhtar
Hi Doug, On Thu, Oct 16, 2014 at 9:40 PM, Doug Anderson diand...@chromium.org wrote: Alim, On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Doug, On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson diand...@chromium.org wrote: The dw_mmc driver had a bunch of code

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Doug Anderson
Alim, On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar wrote: > Hi Doug, > > On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson wrote: >> The dw_mmc driver had a bunch of code that ran whenever a card was >> ejected and inserted. However, this code was old and crufty and >> should be removed. Some

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Doug Anderson
Jaehoon, On Thu, Oct 16, 2014 at 2:38 AM, Jaehoon Chung wrote: > Hi, Doug. > > Add one comment. > > On 10/16/2014 05:19 PM, Jaehoon Chung wrote: >> Hi, Doug. >> >> Looks good to me. >> >> Tested-by: Jaehoon Chung >> with exynos3/4 series. >> >> Need to check exynos5 with using other "card

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Alim Akhtar
Hi Doug, On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson wrote: > The dw_mmc driver had a bunch of code that ran whenever a card was > ejected and inserted. However, this code was old and crufty and > should be removed. Some evidence that it's really not needed: > > 1. Is is supposed to be

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Jaehoon Chung
Hi, Doug. Add one comment. On 10/16/2014 05:19 PM, Jaehoon Chung wrote: > Hi, Doug. > > Looks good to me. > > Tested-by: Jaehoon Chung > with exynos3/4 series. > > Need to check exynos5 with using other "card detect" mechanism. > > Best Regards, > Jaehoon Chung > > On 10/15/2014 01:33 AM,

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Jaehoon Chung
Hi, Doug. Looks good to me. Tested-by: Jaehoon Chung with exynos3/4 series. Need to check exynos5 with using other "card detect" mechanism. Best Regards, Jaehoon Chung On 10/15/2014 01:33 AM, Doug Anderson wrote: > The dw_mmc driver had a bunch of code that ran whenever a card was > ejected

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Jaehoon Chung
Hi, Doug. Looks good to me. Tested-by: Jaehoon Chung jh80.ch...@samsung.com with exynos3/4 series. Need to check exynos5 with using other card detect mechanism. Best Regards, Jaehoon Chung On 10/15/2014 01:33 AM, Doug Anderson wrote: The dw_mmc driver had a bunch of code that ran whenever a

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Jaehoon Chung
Hi, Doug. Add one comment. On 10/16/2014 05:19 PM, Jaehoon Chung wrote: Hi, Doug. Looks good to me. Tested-by: Jaehoon Chung jh80.ch...@samsung.com with exynos3/4 series. Need to check exynos5 with using other card detect mechanism. Best Regards, Jaehoon Chung On 10/15/2014

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Alim Akhtar
Hi Doug, On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson diand...@chromium.org wrote: The dw_mmc driver had a bunch of code that ran whenever a card was ejected and inserted. However, this code was old and crufty and should be removed. Some evidence that it's really not needed: 1. Is is

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Doug Anderson
Jaehoon, On Thu, Oct 16, 2014 at 2:38 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Doug. Add one comment. On 10/16/2014 05:19 PM, Jaehoon Chung wrote: Hi, Doug. Looks good to me. Tested-by: Jaehoon Chung jh80.ch...@samsung.com with exynos3/4 series. Need to check exynos5 with

Re: [PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-16 Thread Doug Anderson
Alim, On Thu, Oct 16, 2014 at 5:57 AM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Doug, On Tue, Oct 14, 2014 at 10:03 PM, Doug Anderson diand...@chromium.org wrote: The dw_mmc driver had a bunch of code that ran whenever a card was ejected and inserted. However, this code was old and

[PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-14 Thread Doug Anderson
The dw_mmc driver had a bunch of code that ran whenever a card was ejected and inserted. However, this code was old and crufty and should be removed. Some evidence that it's really not needed: 1. Is is supposed to be legal to use 'cd-gpio' on dw_mmc instead of using the built-in card detect

[PATCH] mmc: dw_mmc: Remove old card detect infrastructure

2014-10-14 Thread Doug Anderson
The dw_mmc driver had a bunch of code that ran whenever a card was ejected and inserted. However, this code was old and crufty and should be removed. Some evidence that it's really not needed: 1. Is is supposed to be legal to use 'cd-gpio' on dw_mmc instead of using the built-in card detect