Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Heiko Stuebner
Am Montag, 17. August 2015, 12:34:09 schrieb Ulf Hansson: > [...] > > >>> - mmc->max_seg_size = mmc->max_req_size; > >>> -#endif /* CONFIG_MMC_DW_IDMAC */ > >>> + if (host->use_dma) { > >>> + mmc->max_segs = host->ring_size; > >> > >> I expect

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Ulf Hansson
[...] >>> - mmc->max_seg_size = mmc->max_req_size; >>> -#endif /* CONFIG_MMC_DW_IDMAC */ >>> + if (host->use_dma) { >>> + mmc->max_segs = host->ring_size; >> >> I expect this may cause a compiler error since host->ring_size is only >> available in

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Jaehoon Chung
Hi, Ulf. On 08/17/2015 07:16 PM, Ulf Hansson wrote: > On 3 August 2015 at 17:04, Heiko Stübner wrote: >> The dw_mci_init_dma() may decide to not use dma, but pio instead, caused >> by things like wrong dma settings in the system. >> >> Till now the code dw_mci_init_slot() always assumed that dma

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Ulf Hansson
On 3 August 2015 at 17:04, Heiko Stübner wrote: > The dw_mci_init_dma() may decide to not use dma, but pio instead, caused > by things like wrong dma settings in the system. > > Till now the code dw_mci_init_slot() always assumed that dma is available > when CONFIG_MMC_DW_IDMAC was defined,

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Jaehoon Chung
Hi, Ulf. On 08/17/2015 07:16 PM, Ulf Hansson wrote: On 3 August 2015 at 17:04, Heiko Stübner he...@sntech.de wrote: The dw_mci_init_dma() may decide to not use dma, but pio instead, caused by things like wrong dma settings in the system. Till now the code dw_mci_init_slot() always assumed

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Heiko Stuebner
Am Montag, 17. August 2015, 12:34:09 schrieb Ulf Hansson: [...] - mmc-max_seg_size = mmc-max_req_size; -#endif /* CONFIG_MMC_DW_IDMAC */ + if (host-use_dma) { + mmc-max_segs = host-ring_size; I expect this may cause a compiler error

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Ulf Hansson
[...] - mmc-max_seg_size = mmc-max_req_size; -#endif /* CONFIG_MMC_DW_IDMAC */ + if (host-use_dma) { + mmc-max_segs = host-ring_size; I expect this may cause a compiler error since host-ring_size is only available in the struct dw_mci *host

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-17 Thread Ulf Hansson
On 3 August 2015 at 17:04, Heiko Stübner he...@sntech.de wrote: The dw_mci_init_dma() may decide to not use dma, but pio instead, caused by things like wrong dma settings in the system. Till now the code dw_mci_init_slot() always assumed that dma is available when CONFIG_MMC_DW_IDMAC was

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-05 Thread Jaehoon Chung
Hi, Heiko. Applied this patch at my dw-mmc tree. I will request pull on this weekend. Thanks a lot! Best Regards, Jaehoon Chung On 08/04/2015 12:04 AM, Heiko Stübner wrote: > The dw_mci_init_dma() may decide to not use dma, but pio instead, caused > by things like wrong dma settings in the

Re: [PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-05 Thread Jaehoon Chung
Hi, Heiko. Applied this patch at my dw-mmc tree. I will request pull on this weekend. Thanks a lot! Best Regards, Jaehoon Chung On 08/04/2015 12:04 AM, Heiko Stübner wrote: The dw_mci_init_dma() may decide to not use dma, but pio instead, caused by things like wrong dma settings in the

[PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-03 Thread Heiko Stübner
The dw_mci_init_dma() may decide to not use dma, but pio instead, caused by things like wrong dma settings in the system. Till now the code dw_mci_init_slot() always assumed that dma is available when CONFIG_MMC_DW_IDMAC was defined, ignoring the host->use_dma var set during dma init. So when

[PATCH] mmc: dw_mmc: fix pio mode when internal dmac is enabled

2015-08-03 Thread Heiko Stübner
The dw_mci_init_dma() may decide to not use dma, but pio instead, caused by things like wrong dma settings in the system. Till now the code dw_mci_init_slot() always assumed that dma is available when CONFIG_MMC_DW_IDMAC was defined, ignoring the host-use_dma var set during dma init. So when now