Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-25 Thread Alexandru Stan
>From what I understand... High speed SD cards have 1.8V regulators inside them(sourced by vmmc (what we power the SD card with)). So in terms of the SD card IO pins they will either use exactly vmmc or 1.8V. It doesn't make sense for vqmmc (the voltage we use to power the AP block connected to

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-25 Thread Alexandru Stan
From what I understand... High speed SD cards have 1.8V regulators inside them(sourced by vmmc (what we power the SD card with)). So in terms of the SD card IO pins they will either use exactly vmmc or 1.8V. It doesn't make sense for vqmmc (the voltage we use to power the AP block connected to the

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Doug Anderson
Addy, On Mon, Nov 24, 2014 at 6:38 PM, Addy wrote: >> In worst case scenario, VDD = 3.6V and VIO = 2.7V. That gives as the >> factor of 0.75, thus we are inside spec but without margins. > > * From eMMC4.5 spec: > 1. (VDDF)vcc: Supply voltage for flash memory, which is 2.7v -- 3.3v > 2.

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Doug Anderson
Ulf, On Mon, Nov 24, 2014 at 5:29 AM, Ulf Hansson wrote: >> 2. Several people I've talked to have expressed concerns that our >> minimum value is 2.7V. Apparently that's really on the edge and makes >> EEs a little nervous. The quick sample of cards sitting on my desk >> shows that they seem

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Addy
On Fri, Nov 24, 2014 at 9:29 PM, Ulf Hansson wrote: On 21 November 2014 at 22:04, Doug Anderson wrote: Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson wrote: Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson wrote: [...] Sure If the first card is sd2.0 since startup,

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Ulf Hansson
On 21 November 2014 at 22:04, Doug Anderson wrote: > Hi, > > On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson wrote: >> Ulf, >> >> On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson wrote: >>> [...] >>> Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Ulf Hansson
On 21 November 2014 at 22:04, Doug Anderson diand...@chromium.org wrote: Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson ulf.hans...@linaro.org wrote: [...] Sure If the first card is sd2.0 since startup,

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Addy
On Fri, Nov 24, 2014 at 9:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 21 November 2014 at 22:04, Doug Anderson diand...@chromium.org wrote: Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Doug Anderson
Ulf, On Mon, Nov 24, 2014 at 5:29 AM, Ulf Hansson ulf.hans...@linaro.org wrote: 2. Several people I've talked to have expressed concerns that our minimum value is 2.7V. Apparently that's really on the edge and makes EEs a little nervous. The quick sample of cards sitting on my desk shows

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Doug Anderson
Addy, On Mon, Nov 24, 2014 at 6:38 PM, Addy addy...@rock-chips.com wrote: In worst case scenario, VDD = 3.6V and VIO = 2.7V. That gives as the factor of 0.75, thus we are inside spec but without margins. * From eMMC4.5 spec: 1. (VDDF)vcc: Supply voltage for flash memory, which is 2.7v --

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Doug Anderson
Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson wrote: > Ulf, > > On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson wrote: >> [...] >> >>> Sure >>> If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be >>> called, >> >> That can't be right. mmc_power_up() should trigger >>

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Doug Anderson
Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson wrote: > [...] > >> Sure >> If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be >> called, > > That can't be right. mmc_power_up() should trigger > dw_mci_switch_voltage() to be invoked. Hmmm, I think you're right.

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Jaehoon Chung
On 11/21/2014 09:06 PM, Ulf Hansson wrote: > [...] > >> Sure >> If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be >> called, > > That can't be right. mmc_power_up() should trigger > dw_mci_switch_voltage() to be invoked. Since dw_mci_switch_voltage() is invoked,

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Ulf Hansson
[...] > Sure > If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be > called, That can't be right. mmc_power_up() should trigger dw_mci_switch_voltage() to be invoked. > and card can be identified. But if UHS card is pulgged in first, the vqmmc > will be down to 1.8v. >

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Ulf Hansson
[...] Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be called, That can't be right. mmc_power_up() should trigger dw_mci_switch_voltage() to be invoked. and card can be identified. But if UHS card is pulgged in first, the vqmmc will be down to 1.8v. when

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Jaehoon Chung
On 11/21/2014 09:06 PM, Ulf Hansson wrote: [...] Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be called, That can't be right. mmc_power_up() should trigger dw_mci_switch_voltage() to be invoked. Since dw_mci_switch_voltage() is invoked, voltage is

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Doug Anderson
Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson ulf.hans...@linaro.org wrote: [...] Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be called, That can't be right. mmc_power_up() should trigger dw_mci_switch_voltage() to be invoked. Hmmm, I think you're

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Doug Anderson
Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson ulf.hans...@linaro.org wrote: [...] Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be called, That can't be right.

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-12 Thread addy ke
On 2014/11/13 02:04, Doug Anderson wrote: > Ulf, > > On Tue, Nov 11, 2014 at 12:52 AM, Ulf Hansson wrote: >> On 11 November 2014 05:02, Addy Ke wrote: >>> SD2.0 cards need vqmmc and vmmc to be the same. >> >> No, that's not correct. >> >> If I remember the spec correctly, the bus signal

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-12 Thread Doug Anderson
Ulf, On Tue, Nov 11, 2014 at 12:52 AM, Ulf Hansson wrote: > On 11 November 2014 05:02, Addy Ke wrote: >> SD2.0 cards need vqmmc and vmmc to be the same. > > No, that's not correct. > > If I remember the spec correctly, the bus signal threshold is 0.75 * VDD. As usual, I will first state my

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-12 Thread Doug Anderson
Ulf, On Tue, Nov 11, 2014 at 12:52 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 11 November 2014 05:02, Addy Ke addy...@rock-chips.com wrote: SD2.0 cards need vqmmc and vmmc to be the same. No, that's not correct. If I remember the spec correctly, the bus signal threshold is 0.75 * VDD.

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-12 Thread addy ke
On 2014/11/13 02:04, Doug Anderson wrote: Ulf, On Tue, Nov 11, 2014 at 12:52 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 11 November 2014 05:02, Addy Ke addy...@rock-chips.com wrote: SD2.0 cards need vqmmc and vmmc to be the same. No, that's not correct. If I remember the spec

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-11 Thread Ulf Hansson
On 11 November 2014 05:02, Addy Ke wrote: > SD2.0 cards need vqmmc and vmmc to be the same. No, that's not correct. If I remember the spec correctly, the bus signal threshold is 0.75 * VDD. > But vqmmc call regulator_set_voltage to set min_uv(2.7v) as far as possible. I guess you want to do

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-11 Thread Ulf Hansson
On 11 November 2014 05:02, Addy Ke addy...@rock-chips.com wrote: SD2.0 cards need vqmmc and vmmc to be the same. No, that's not correct. If I remember the spec correctly, the bus signal threshold is 0.75 * VDD. But vqmmc call regulator_set_voltage to set min_uv(2.7v) as far as possible. I

[PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-10 Thread Addy Ke
SD2.0 cards need vqmmc and vmmc to be the same. But vqmmc call regulator_set_voltage to set min_uv(2.7v) as far as possible. So if we set vmmc 3.3V in dt table, we will get error information as follows: [ 17.785398] mmc_host mmc1: Bus speed (slot 0) = 5000Hz (slot req 5000Hz, actual

[PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-10 Thread Addy Ke
SD2.0 cards need vqmmc and vmmc to be the same. But vqmmc call regulator_set_voltage to set min_uv(2.7v) as far as possible. So if we set vmmc 3.3V in dt table, we will get error information as follows: [ 17.785398] mmc_host mmc1: Bus speed (slot 0) = 5000Hz (slot req 5000Hz, actual