Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-09 Thread Daniel Drake
Ivan Kokshaysky wrote: On alpha, ia64 and ppc64 only relocations to local data can go into read-only sections. The vast majority of module parameters use the global generic param_set_*/param_get_* functions, so the 'const' attribute for struct kernel_param is not only useless, but it also causes

Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-09 Thread Daniel Drake
Ivan Kokshaysky wrote: On alpha, ia64 and ppc64 only relocations to local data can go into read-only sections. The vast majority of module parameters use the global generic param_set_*/param_get_* functions, so the 'const' attribute for struct kernel_param is not only useless, but it also causes

Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Ivan Kokshaysky
On Fri, Feb 08, 2008 at 02:46:15PM -0800, Andrew Morton wrote: > I think it would have been better to define a new CONFIG_MODULEPARAM_CONST > for those three archictures, rather than muckying up the code like this. I'd prefer to keep this as is for now (sorta the uglier the better ;-) I really

Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Andrew Morton
On Sat, 9 Feb 2008 01:33:41 +0300 Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > On alpha, ia64 and ppc64 only relocations to local data can go into > read-only sections. The vast majority of module parameters use the global > generic param_set_*/param_get_* functions, so the 'const' attribute for

[PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Ivan Kokshaysky
On alpha, ia64 and ppc64 only relocations to local data can go into read-only sections. The vast majority of module parameters use the global generic param_set_*/param_get_* functions, so the 'const' attribute for struct kernel_param is not only useless, but it also causes compile failures due to

[PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Ivan Kokshaysky
On alpha, ia64 and ppc64 only relocations to local data can go into read-only sections. The vast majority of module parameters use the global generic param_set_*/param_get_* functions, so the 'const' attribute for struct kernel_param is not only useless, but it also causes compile failures due to

Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Andrew Morton
On Sat, 9 Feb 2008 01:33:41 +0300 Ivan Kokshaysky [EMAIL PROTECTED] wrote: On alpha, ia64 and ppc64 only relocations to local data can go into read-only sections. The vast majority of module parameters use the global generic param_set_*/param_get_* functions, so the 'const' attribute for

Re: [PATCH] moduleparam: fix alpha, ia64 and ppc64 compile failures

2008-02-08 Thread Ivan Kokshaysky
On Fri, Feb 08, 2008 at 02:46:15PM -0800, Andrew Morton wrote: I think it would have been better to define a new CONFIG_MODULEPARAM_CONST for those three archictures, rather than muckying up the code like this. I'd prefer to keep this as is for now (sorta the uglier the better ;-) I really hope