Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-29 Thread Chuck Ebbert
Brian Braunstein wrote: > > From: Brian Braunstein <[EMAIL PROTECTED]> > > Fixed tun/tap driver's handling of hw addresses. Okay, the attached patch applies. Can someone comment on whether it makes sense? (pasted inline for comments) From: Brian Braunstein <[EMAIL PROTECTED]> Fixed tun/tap

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-29 Thread Chuck Ebbert
Brian Braunstein wrote: From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. Okay, the attached patch applies. Can someone comment on whether it makes sense? (pasted inline for comments) From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Chuck Ebbert
Brian Braunstein wrote: > > From: Brian Braunstein <[EMAIL PROTECTED]> > > Fixed tun/tap driver's handling of hw addresses. The hw address is > stored in > both the net_device.dev_addr and tun.dev_addr fields. These fields were > not > kept synchronized, and in fact weren't even initialized to

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Mon, Mar 26, 2007 at 10:55:11PM +0200, ahmed wrote: > On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: > > --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23 > > 12:52:51.0 -0700 > > +++ linux-2.6.20.4/drivers/net/tun.c2007-03-25 00:44:20.0 > >

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: > > From: Brian Braunstein <[EMAIL PROTECTED]> > No need for this line. This line is used when you _forward_ another patch from others. Signed-off-by is enough > > Signed-off-by: Brian Braunstein <[EMAIL PROTECTED]> > > --- >

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: From: Brian Braunstein [EMAIL PROTECTED] No need for this line. This line is used when you _forward_ another patch from others. Signed-off-by is enough Signed-off-by: Brian Braunstein [EMAIL PROTECTED] --- Kernel

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Mon, Mar 26, 2007 at 10:55:11PM +0200, ahmed wrote: On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23 12:52:51.0 -0700 +++ linux-2.6.20.4/drivers/net/tun.c2007-03-25 00:44:20.0 -0700 @@

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Chuck Ebbert
Brian Braunstein wrote: From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same

[PATCH] net: tun/tap: fixed hw address handling

2007-03-25 Thread Brian Braunstein
From: Brian Braunstein <[EMAIL PROTECTED]> Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same value. Now during both init

[PATCH] net: tun/tap: fixed hw address handling

2007-03-25 Thread Brian Braunstein
From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same value. Now during both init and