Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Andries . Brouwer
> your arguments appear correct to me > I include the patch to be applied from my point of view Good. Had no time today to look at the details, but at first sight this is a big improvement. May want to nitpick a little some other time. Andries - To unsubscribe from this list: send the line

Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Holger . Smolinski
Andries, okay, your arguments appear correct to me. Additionally there has some other work to be done... I include the patch to be applied from my point of view: (See attached file: ibmpart.diff) It includes the adaptions to the dasd_*.c files in drivers/s390/block and also should fix the

[PATCH] partitions/ibm.c

2001-02-26 Thread Holger . Smolinski
Andries, others, Thanks for hacking through the code of fs/partitions/ibm.c. Your patch does not work at all because you are relying on the data in the part component of the hd structure, which does not hold the geometry data of the disk but the data of the partitions on that disk. Besides

Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Andries . Brouwer
From [EMAIL PROTECTED] Mon Feb 26 12:10:59 2001 Andries, others, Thanks for hacking through the code of fs/partitions/ibm.c. Your patch does not work at all because you are relying on the data in the part component of the hd structure, which does not hold the geometry

[PATCH] partitions/ibm.c

2001-02-26 Thread Holger . Smolinski
Andries, others, Thanks for hacking through the code of fs/partitions/ibm.c. Your patch does not work at all because you are relying on the data in the part component of the hd structure, which does not hold the geometry data of the disk but the data of the partitions on that disk. Besides

Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Andries . Brouwer
From [EMAIL PROTECTED] Mon Feb 26 12:10:59 2001 Andries, others, Thanks for hacking through the code of fs/partitions/ibm.c. Your patch does not work at all because you are relying on the data in the part component of the hd structure, which does not hold the geometry

Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Holger . Smolinski
Andries, okay, your arguments appear correct to me. Additionally there has some other work to be done... I include the patch to be applied from my point of view: (See attached file: ibmpart.diff) It includes the adaptions to the dasd_*.c files in drivers/s390/block and also should fix the

Re: [PATCH] partitions/ibm.c

2001-02-26 Thread Andries . Brouwer
your arguments appear correct to me I include the patch to be applied from my point of view Good. Had no time today to look at the details, but at first sight this is a big improvement. May want to nitpick a little some other time. Andries - To unsubscribe from this list: send the line

[PATCH] partitions/ibm.c

2001-02-23 Thread Guest section DW
Reading patch-2.4.2 I met a strange amount of crap in partitions/ibm.c. It is as if the author does not know where the kernel keeps the starting offset of a partition, and simulates a HDIO_GETGEO ioctl from user space. I think the following patch does the same and removes a lot of cruft.

[PATCH] partitions/ibm.c

2001-02-23 Thread Guest section DW
Reading patch-2.4.2 I met a strange amount of crap in partitions/ibm.c. It is as if the author does not know where the kernel keeps the starting offset of a partition, and simulates a HDIO_GETGEO ioctl from user space. I think the following patch does the same and removes a lot of cruft.