Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-08 Thread Milian Wolff
On Freitag, 5. Oktober 2018 15:48:31 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 03, 2018 at 09:05:37AM +0530, Ravi Bangoria escreveu: > > LGTM. > > > > Tested-by: Ravi Bangoria > > So, I've added this as a 'git rebase -i' 'fixup', i.e. kept the commit > log message for the patch this

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-08 Thread Milian Wolff
On Freitag, 5. Oktober 2018 15:48:31 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 03, 2018 at 09:05:37AM +0530, Ravi Bangoria escreveu: > > LGTM. > > > > Tested-by: Ravi Bangoria > > So, I've added this as a 'git rebase -i' 'fixup', i.e. kept the commit > log message for the patch this

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-05 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: > Signed-off-by: Milian Wolff > Cc: Arnaldo Carvalho de Melo > Reported-by: Ravi Bangoria > # Tested-by: > # Reviewed-by: > # Suggested-b: > Fixes: bfe16b0653 ("perf report: Don't crash on invalid inline debug > information")

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-05 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: > Signed-off-by: Milian Wolff > Cc: Arnaldo Carvalho de Melo > Reported-by: Ravi Bangoria > # Tested-by: > # Reviewed-by: > # Suggested-b: > Fixes: bfe16b0653 ("perf report: Don't crash on invalid inline debug > information")

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-05 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 03, 2018 at 09:05:37AM +0530, Ravi Bangoria escreveu: > LGTM. > Tested-by: Ravi Bangoria So, I've added this as a 'git rebase -i' 'fixup', i.e. kept the commit log message for the patch this patch fixes, and combined the two into just one patch so that we don't pollute the bisect

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-05 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 03, 2018 at 09:05:37AM +0530, Ravi Bangoria escreveu: > LGTM. > Tested-by: Ravi Bangoria So, I've added this as a 'git rebase -i' 'fixup', i.e. kept the commit log message for the patch this patch fixes, and combined the two into just one patch so that we don't pollute the bisect

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Ravi Bangoria
On 10/02/2018 09:02 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: >> Only use the mapped IP to find inline frames, but keep >> using the unmapped IP for the callchain cursor. This >> ensures we properly show the unmapped IP when

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Ravi Bangoria
On 10/02/2018 09:02 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: >> Only use the mapped IP to find inline frames, but keep >> using the unmapped IP for the callchain cursor. This >> ensures we properly show the unmapped IP when

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: > Only use the mapped IP to find inline frames, but keep > using the unmapped IP for the callchain cursor. This > ensures we properly show the unmapped IP when displaying > a frame we received via the dso__parse_addr_inlines API >

Re: [PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2018 at 09:39:49AM +0200, Milian Wolff escreveu: > Only use the mapped IP to find inline frames, but keep > using the unmapped IP for the callchain cursor. This > ensures we properly show the unmapped IP when displaying > a frame we received via the dso__parse_addr_inlines API >

[PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Milian Wolff
Only use the mapped IP to find inline frames, but keep using the unmapped IP for the callchain cursor. This ensures we properly show the unmapped IP when displaying a frame we received via the dso__parse_addr_inlines API for a module which does not contain sufficient debug symbols to show the

[PATCH] perf record: use unmapped IP for inline callchain cursors

2018-10-02 Thread Milian Wolff
Only use the mapped IP to find inline frames, but keep using the unmapped IP for the callchain cursor. This ensures we properly show the unmapped IP when displaying a frame we received via the dso__parse_addr_inlines API for a module which does not contain sufficient debug symbols to show the