Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 04:00:12PM +0900, Namhyung Kim escreveu: > On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: > > When 'perf record' write headers, it calls write_xxx in > > tools/perf/util/header.c, and check return value. It rolls back all > > working only when return value is negative.

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-23 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 22, 2014 at 04:00:12PM +0900, Namhyung Kim escreveu: On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls back all working only when return value is negative.

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Wang Nan
Hi Ingo, Could you please collect this patch which fixes a perf problem? Thanks. On 2014/10/22 15:00, Namhyung Kim wrote: > On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: >> When 'perf record' write headers, it calls write_xxx in >> tools/perf/util/header.c, and check return value. It

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Wang Nan
On 2014/10/22 15:00, Namhyung Kim wrote: > On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: >> When 'perf record' write headers, it calls write_xxx in >> tools/perf/util/header.c, and check return value. It rolls back all >> working only when return value is negative. >> >> This patch ensures

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Namhyung Kim
On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: > When 'perf record' write headers, it calls write_xxx in > tools/perf/util/header.c, and check return value. It rolls back all > working only when return value is negative. > > This patch ensures write_cpudesc() and write_total_mem() return

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Wang Nan
Hi Ingo, Could you please collect this patch which fixes a perf problem? Thanks. On 2014/10/22 15:00, Namhyung Kim wrote: On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Namhyung Kim
On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls back all working only when return value is negative. This patch ensures write_cpudesc() and write_total_mem() return negative

Re: [PATCH] perf tools: ensure return negitive value when write header error

2014-10-22 Thread Wang Nan
On 2014/10/22 15:00, Namhyung Kim wrote: On Thu, 16 Oct 2014 11:08:29 +0800, Wang Nan wrote: When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls back all working only when return value is negative. This patch ensures

[PATCH] perf tools: ensure return negitive value when write header error

2014-10-15 Thread Wang Nan
When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls back all working only when return value is negative. This patch ensures write_cpudesc() and write_total_mem() return negative number when error. Without this patch, headers reported

[PATCH] perf tools: ensure return negitive value when write header error

2014-10-15 Thread Wang Nan
When 'perf record' write headers, it calls write_xxx in tools/perf/util/header.c, and check return value. It rolls back all working only when return value is negative. This patch ensures write_cpudesc() and write_total_mem() return negative number when error. Without this patch, headers reported