Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-13 Thread Linus Walleij
On Fri, Sep 9, 2016 at 11:26 AM, Arnd Bergmann wrote: > The newly added aspeed driver tries to check for a negative return > value from a pinctrl function, but stores the intermediate value in > a 'bool' variable, which cannot work: > > drivers/pinctrl/aspeed/pinctrl-aspeed.c: In

Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-13 Thread Linus Walleij
On Fri, Sep 9, 2016 at 11:26 AM, Arnd Bergmann wrote: > The newly added aspeed driver tries to check for a negative return > value from a pinctrl function, but stores the intermediate value in > a 'bool' variable, which cannot work: > > drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function

Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-11 Thread Andrew Jeffery
On Mon, 2016-09-12 at 10:52 +0930, Joel Stanley wrote: > On Fri, Sep 9, 2016 at 6:56 PM, Arnd Bergmann wrote: > > > > The newly added aspeed driver tries to check for a negative return > > value from a pinctrl function, but stores the intermediate value in > > a 'bool' variable,

Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-11 Thread Andrew Jeffery
On Mon, 2016-09-12 at 10:52 +0930, Joel Stanley wrote: > On Fri, Sep 9, 2016 at 6:56 PM, Arnd Bergmann wrote: > > > > The newly added aspeed driver tries to check for a negative return > > value from a pinctrl function, but stores the intermediate value in > > a 'bool' variable, which cannot

Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-11 Thread Joel Stanley
On Fri, Sep 9, 2016 at 6:56 PM, Arnd Bergmann wrote: > The newly added aspeed driver tries to check for a negative return > value from a pinctrl function, but stores the intermediate value in > a 'bool' variable, which cannot work: > > drivers/pinctrl/aspeed/pinctrl-aspeed.c: In

Re: [PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-11 Thread Joel Stanley
On Fri, Sep 9, 2016 at 6:56 PM, Arnd Bergmann wrote: > The newly added aspeed driver tries to check for a negative return > value from a pinctrl function, but stores the intermediate value in > a 'bool' variable, which cannot work: > > drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function

[PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-09 Thread Arnd Bergmann
The newly added aspeed driver tries to check for a negative return value from a pinctrl function, but stores the intermediate value in a 'bool' variable, which cannot work: drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function 'aspeed_sig_expr_set': drivers/pinctrl/aspeed/pinctrl-aspeed.c:192:11:

[PATCH] pinctrl: aspeed: fix regmap error handling

2016-09-09 Thread Arnd Bergmann
The newly added aspeed driver tries to check for a negative return value from a pinctrl function, but stores the intermediate value in a 'bool' variable, which cannot work: drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function 'aspeed_sig_expr_set': drivers/pinctrl/aspeed/pinctrl-aspeed.c:192:11: