Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-13 Thread Linus Walleij
On Sun, Sep 11, 2016 at 10:36 AM, Colin King wrote: > From: Colin Ian King > > Macro regmap_update_bits can return a -ve on an error value so ret > needs to be an integer rather than a bool type. > > Fixes warning found by static analysis with

Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-13 Thread Linus Walleij
On Sun, Sep 11, 2016 at 10:36 AM, Colin King wrote: > From: Colin Ian King > > Macro regmap_update_bits can return a -ve on an error value so ret > needs to be an integer rather than a bool type. > > Fixes warning found by static analysis with cppcheck: >

Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-11 Thread Andrew Jeffery
On Sun, 2016-09-11 at 09:36 +0100, Colin King wrote: > From: Colin Ian King > > Macro regmap_update_bits can return a -ve on an error value so ret > needs to be an integer rather than a bool type. > > Fixes warning found by static analysis with cppcheck: >

Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-11 Thread Andrew Jeffery
On Sun, 2016-09-11 at 09:36 +0100, Colin King wrote: > From: Colin Ian King > > Macro regmap_update_bits can return a -ve on an error value so ret > needs to be an integer rather than a bool type. > > Fixes warning found by static analysis with cppcheck: >

[PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-11 Thread Colin King
From: Colin Ian King Macro regmap_update_bits can return a -ve on an error value so ret needs to be an integer rather than a bool type. Fixes warning found by static analysis with cppcheck: [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of a

[PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

2016-09-11 Thread Colin King
From: Colin Ian King Macro regmap_update_bits can return a -ve on an error value so ret needs to be an integer rather than a bool type. Fixes warning found by static analysis with cppcheck: [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of a boolean expression with an