Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-23 Thread Linus Walleij
On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-23 Thread Linus Walleij
On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So we may hit this case: >

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-15 Thread Heiko Stuebner
Am Donnerstag, 2. März 2017, 13:56:52 CET schrieb Jeffy Chen: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So we may hit this

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-15 Thread Heiko Stuebner
Am Donnerstag, 2. März 2017, 13:56:52 CET schrieb Jeffy Chen: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So we may hit this

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-14 Thread Heiko Stübner
Hi Linus, Am Dienstag, 14. März 2017, 16:03:48 CET schrieb Linus Walleij: > On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > > Currently we are trying to enable/disable the clk of irq's gpio bank when > > unmask/mask irq. But the kernel's "lazy disable approach"

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-14 Thread Heiko Stübner
Hi Linus, Am Dienstag, 14. März 2017, 16:03:48 CET schrieb Linus Walleij: > On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > > Currently we are trying to enable/disable the clk of irq's gpio bank when > > unmask/mask irq. But the kernel's "lazy disable approach" will skip > > masking > > irq

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen wrote: > Currently we are trying to enable/disable the clk of irq's gpio bank when > unmask/mask irq. But the kernel's "lazy disable approach" will skip masking > irq when the irq chip doesn't support irq_disable ops. > > So we may hit this case: >

[PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-01 Thread Jeffy Chen
Currently we are trying to enable/disable the clk of irq's gpio bank when unmask/mask irq. But the kernel's "lazy disable approach" will skip masking irq when the irq chip doesn't support irq_disable ops. So we may hit this case: irq_enable-> enable clk irq_disable-> noop

[PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

2017-03-01 Thread Jeffy Chen
Currently we are trying to enable/disable the clk of irq's gpio bank when unmask/mask irq. But the kernel's "lazy disable approach" will skip masking irq when the irq chip doesn't support irq_disable ops. So we may hit this case: irq_enable-> enable clk irq_disable-> noop