Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
On Mon, 28 Nov 2016 09:31:03 -0800 Jacob Pan wrote: > > Also, it looks like a Fixes: tag should be present here. > > I just resent the patch with Fixes: tag. Thanks, Jacob

Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
On Mon, 28 Nov 2016 09:31:03 -0800 Jacob Pan wrote: > > Also, it looks like a Fixes: tag should be present here. > > I just resent the patch with Fixes: tag. Thanks, Jacob

[PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added contraint_to_pl() function to return index into an array. But it can potentially return -EINVAL if powercap layer sends an out of range constraint ID. This patch adds sanity check. Unnecessary RAPL domain pointer check is removed

[PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added contraint_to_pl() function to return index into an array. But it can potentially return -EINVAL if powercap layer sends an out of range constraint ID. This patch adds sanity check. Unnecessary RAPL domain pointer check is removed

Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
On Thu, 24 Nov 2016 22:06:59 +0100 "Rafael J. Wysocki" wrote: > On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan > wrote: > > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added > > contraint_to_pl() function to return index into an

Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-28 Thread Jacob Pan
On Thu, 24 Nov 2016 22:06:59 +0100 "Rafael J. Wysocki" wrote: > On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan > wrote: > > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added > > contraint_to_pl() function to return index into an array. But it > > can potentially return -EINVAL if

Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-24 Thread Rafael J. Wysocki
On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan wrote: > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added > contraint_to_pl() function to return index into an array. But it > can potentially return -EINVAL if powercap layer sends an out of > range

Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-24 Thread Rafael J. Wysocki
On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan wrote: > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added > contraint_to_pl() function to return index into an array. But it > can potentially return -EINVAL if powercap layer sends an out of > range constraint ID. This patch adds

[PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-23 Thread Jacob Pan
Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added contraint_to_pl() function to return index into an array. But it can potentially return -EINVAL if powercap layer sends an out of range constraint ID. This patch adds sanity check. Unnecessary RAPL domain pointer check is removed

[PATCH] powercap/intel_rapl: fix and tidy up error handling

2016-11-23 Thread Jacob Pan
Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added contraint_to_pl() function to return index into an array. But it can potentially return -EINVAL if powercap layer sends an out of range constraint ID. This patch adds sanity check. Unnecessary RAPL domain pointer check is removed