Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:33:35PM -0500, Steven Rostedt wrote: > On Tue, 2 Mar 2021 17:30:58 -0500 > Steven Rostedt wrote: > > > I just realized that I received this patch twice, and thought it was the > > same patch! Chen was three days ahead of you, so he get's the credit ;-) > > > >

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-03 Thread Li Huafei
On 2021/3/3 6:30, Steven Rostedt wrote: On Thu, 25 Feb 2021 16:01:17 + Will Deacon wrote: On Thu, Feb 25, 2021 at 09:44:26AM -0500, Steven Rostedt wrote: This requires an acked-by from one of the ARM64 maintainers. -- Steve On Thu, 25 Feb 2021 22:07:47 +0800 Li Huafei wrote:

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-02 Thread Steven Rostedt
On Tue, 2 Mar 2021 17:30:58 -0500 Steven Rostedt wrote: > I just realized that I received this patch twice, and thought it was the > same patch! Chen was three days ahead of you, so he get's the credit ;-) > > https://lore.kernel.org/r/20210222135840.56250-1-chenjun...@huawei.com I'm applying

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-02 Thread Steven Rostedt
On Thu, 25 Feb 2021 16:01:17 + Will Deacon wrote: > On Thu, Feb 25, 2021 at 09:44:26AM -0500, Steven Rostedt wrote: > > This requires an acked-by from one of the ARM64 maintainers. > > > > -- Steve > > > > > > On Thu, 25 Feb 2021 22:07:47 +0800 > > Li Huafei wrote: > > > > > When

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-02-25 Thread Steven Rostedt
On Thu, 25 Feb 2021 16:01:17 + Will Deacon wrote: > Acked-by: Will Deacon Thanks! > > But you know you could avoid these sorts of problems by moving to little > endian along with everybody else? ;) But then how do we find these bug? -- Steve

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-02-25 Thread Will Deacon
On Thu, Feb 25, 2021 at 09:44:26AM -0500, Steven Rostedt wrote: > This requires an acked-by from one of the ARM64 maintainers. > > -- Steve > > > On Thu, 25 Feb 2021 22:07:47 +0800 > Li Huafei wrote: > > > When cross-compiling the kernel, the endian of the target machine and > > the local

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-02-25 Thread Steven Rostedt
This requires an acked-by from one of the ARM64 maintainers. -- Steve On Thu, 25 Feb 2021 22:07:47 +0800 Li Huafei wrote: > When cross-compiling the kernel, the endian of the target machine and > the local machine may not match, at this time the recordmcount tool > needs byte reversal when

[PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-02-25 Thread Li Huafei
When cross-compiling the kernel, the endian of the target machine and the local machine may not match, at this time the recordmcount tool needs byte reversal when processing elf's variables to get the correct value. w* callback function is used to solve this problem, w is used for 4-byte variable