Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/03/31 at 11:52, Xunlei Pang wrote: > Hi Bao, > > On 2016/03/31 at 10:52, Baoquan He wrote: >> On 03/31/16 at 10:43am, Minfei Huang wrote: >>> On 03/30/16 at 08:30pm, Baoquan He wrote: Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/03/31 at 11:52, Xunlei Pang wrote: > Hi Bao, > > On 2016/03/31 at 10:52, Baoquan He wrote: >> On 03/31/16 at 10:43am, Minfei Huang wrote: >>> On 03/30/16 at 08:30pm, Baoquan He wrote: Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/04/04 at 22:58, Michael Holzheu wrote: > Hello Xunlei, > > On Sat, 2 Apr 2016 09:23:50 +0800 > Xunlei Pang wrote: > >> On 2016/04/02 at 01:41, Michael Holzheu wrote: >>> Hello Xunlei again, >>> >>> Some initial comments below... >>> >>> On Wed, 30 Mar 2016 19:47:21 +0800

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/04/04 at 22:58, Michael Holzheu wrote: > Hello Xunlei, > > On Sat, 2 Apr 2016 09:23:50 +0800 > Xunlei Pang wrote: > >> On 2016/04/02 at 01:41, Michael Holzheu wrote: >>> Hello Xunlei again, >>> >>> Some initial comments below... >>> >>> On Wed, 30 Mar 2016 19:47:21 +0800 >>> Xunlei Pang

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei, On Sat, 2 Apr 2016 09:23:50 +0800 Xunlei Pang wrote: > On 2016/04/02 at 01:41, Michael Holzheu wrote: > > Hello Xunlei again, > > > > Some initial comments below... > > > > On Wed, 30 Mar 2016 19:47:21 +0800 > > Xunlei Pang wrote: > > [snip]

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei, On Sat, 2 Apr 2016 09:23:50 +0800 Xunlei Pang wrote: > On 2016/04/02 at 01:41, Michael Holzheu wrote: > > Hello Xunlei again, > > > > Some initial comments below... > > > > On Wed, 30 Mar 2016 19:47:21 +0800 > > Xunlei Pang wrote: > > [snip] > >> +

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/04/02 at 01:41, Michael Holzheu wrote: > Hello Xunlei again, > > Some initial comments below... > > On Wed, 30 Mar 2016 19:47:21 +0800 > Xunlei Pang wrote: > >> Commit 3f625002581b ("kexec: introduce a protection mechanism >> for the crashkernel reserved memory") is a

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 2016/04/02 at 01:41, Michael Holzheu wrote: > Hello Xunlei again, > > Some initial comments below... > > On Wed, 30 Mar 2016 19:47:21 +0800 > Xunlei Pang wrote: > >> Commit 3f625002581b ("kexec: introduce a protection mechanism >> for the crashkernel reserved memory") is a similar mechanism >>

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei again, Some initial comments below... On Wed, 30 Mar 2016 19:47:21 +0800 Xunlei Pang wrote: > Commit 3f625002581b ("kexec: introduce a protection mechanism > for the crashkernel reserved memory") is a similar mechanism > for protecting the crash kernel reserved

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei again, Some initial comments below... On Wed, 30 Mar 2016 19:47:21 +0800 Xunlei Pang wrote: > Commit 3f625002581b ("kexec: introduce a protection mechanism > for the crashkernel reserved memory") is a similar mechanism > for protecting the crash kernel reserved memory to previous

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei, This patch can has potential to create some funny side effects. Especially the change from memblock_remove() to memblock_reserve() and the later call of reserve_crashkernel(). Give me some time. I will look into this next week. Michael On Wed, 30 Mar 2016 19:47:21 +0800 Xunlei

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hello Xunlei, This patch can has potential to create some funny side effects. Especially the change from memblock_remove() to memblock_reserve() and the later call of reserve_crashkernel(). Give me some time. I will look into this next week. Michael On Wed, 30 Mar 2016 19:47:21 +0800 Xunlei

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hi Bao, On 2016/03/31 at 10:52, Baoquan He wrote: > On 03/31/16 at 10:43am, Minfei Huang wrote: >> On 03/30/16 at 08:30pm, Baoquan He wrote: >>> Hi Xunlei, >>> >>> I have two questions. >>> >>> One is do we still need Minfei's patch if this patch is applied since >>> you have completely delete

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hi Bao, On 2016/03/31 at 10:52, Baoquan He wrote: > On 03/31/16 at 10:43am, Minfei Huang wrote: >> On 03/30/16 at 08:30pm, Baoquan He wrote: >>> Hi Xunlei, >>> >>> I have two questions. >>> >>> One is do we still need Minfei's patch if this patch is applied since >>> you have completely delete

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 03/31/16 at 10:43am, Minfei Huang wrote: > On 03/30/16 at 08:30pm, Baoquan He wrote: > > Hi Xunlei, > > > > I have two questions. > > > > One is do we still need Minfei's patch if this patch is applied since > > you have completely delete crash_map/unmap_reserved_pages in > > kernel/kexec.c ?

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 03/31/16 at 10:43am, Minfei Huang wrote: > On 03/30/16 at 08:30pm, Baoquan He wrote: > > Hi Xunlei, > > > > I have two questions. > > > > One is do we still need Minfei's patch if this patch is applied since > > you have completely delete crash_map/unmap_reserved_pages in > > kernel/kexec.c ?

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 03/30/16 at 08:30pm, Baoquan He wrote: > Hi Xunlei, > > I have two questions. > > One is do we still need Minfei's patch if this patch is applied since > you have completely delete crash_map/unmap_reserved_pages in > kernel/kexec.c ? I think it is necessary to apply my bug-fixing patch

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

On 03/30/16 at 08:30pm, Baoquan He wrote: > Hi Xunlei, > > I have two questions. > > One is do we still need Minfei's patch if this patch is applied since > you have completely delete crash_map/unmap_reserved_pages in > kernel/kexec.c ? I think it is necessary to apply my bug-fixing patch

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this patch is applied since you have completely delete crash_map/unmap_reserved_pages in kernel/kexec.c ? On 03/30/16 at 07:47pm, Xunlei Pang wrote: > Commit 3f625002581b ("kexec: introduce a protection mechanism > for

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this patch is applied since you have completely delete crash_map/unmap_reserved_pages in kernel/kexec.c ? On 03/30/16 at 07:47pm, Xunlei Pang wrote: > Commit 3f625002581b ("kexec: introduce a protection mechanism > for

[PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Commit 3f625002581b ("kexec: introduce a protection mechanism for the crashkernel reserved memory") is a similar mechanism for protecting the crash kernel reserved memory to previous crash_map/unmap_reserved_pages() implementation, the new one is more generic in name and cleaner in code (besides,

[PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

Commit 3f625002581b ("kexec: introduce a protection mechanism for the crashkernel reserved memory") is a similar mechanism for protecting the crash kernel reserved memory to previous crash_map/unmap_reserved_pages() implementation, the new one is more generic in name and cleaner in code (besides,