Re: [PATCH] saa7146: fix sparse warnings

On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: Could you please use more descriptive names? NULL noise removal is not the same as shadowing or endianness annotations or endianness fixes or __user/__iomem annotations/fixes, etc. -- To unsubscribe from this list: send the line

Re: [PATCH] saa7146: fix sparse warnings

On Thu, 2008-02-21 at 21:19 +, Al Viro wrote: > On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: > > Could you please use more descriptive names? NULL noise removal > is not the same as shadowing or endianness annotations or endianness > fixes or __user/__iomem

[PATCH] saa7146: fix sparse warnings

Went along with the existing file style. drivers/media/common/saa7146_core.c:309:6: warning: Using plain integer as NULL pointer drivers/media/common/saa7146_core.c:311:8: warning: Using plain integer as NULL pointer drivers/media/common/saa7146_core.c:319:7: warning: Using plain integer as NULL

[PATCH] saa7146: fix sparse warnings

Went along with the existing file style. drivers/media/common/saa7146_core.c:309:6: warning: Using plain integer as NULL pointer drivers/media/common/saa7146_core.c:311:8: warning: Using plain integer as NULL pointer drivers/media/common/saa7146_core.c:319:7: warning: Using plain integer as NULL

Re: [PATCH] saa7146: fix sparse warnings

On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: Could you please use more descriptive names? NULL noise removal is not the same as shadowing or endianness annotations or endianness fixes or __user/__iomem annotations/fixes, etc. -- To unsubscribe from this list: send the line

Re: [PATCH] saa7146: fix sparse warnings

On Thu, 2008-02-21 at 21:19 +, Al Viro wrote: On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: Could you please use more descriptive names? NULL noise removal is not the same as shadowing or endianness annotations or endianness fixes or __user/__iomem annotations/fixes,