Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-28 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 20 Sep 2007, Jeff Garzik wrote: Remove the "linux-" prefix. Hmm, it looks like a

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-28 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- On Thu, 20 Sep 2007, Jeff Garzik wrote: Remove the linux- prefix. Hmm, it looks like a bad

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 20 Sep 2007, Jeff Garzik wrote: > Remove the "linux-" prefix. Hmm, it looks like a bad application of `sed' by

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
On Thu, 20 Sep 2007, Jeff Garzik wrote: > > You may be pleased (or less so) to hear that the version of sb1250-mac.c in > > your tree does not even build (because of > > 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not > > address it. I ran out of time in the evening, but I

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the evening, but I will

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- On Thu, 20 Sep 2007, Jeff Garzik wrote: Remove the linux- prefix. Hmm, it looks like a bad application of `sed' by

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-19 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 13 Sep 2007, Jeff Garzik wrote: Net driver patches should apply on top of

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-19 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- On Thu, 13 Sep 2007, Jeff Garzik wrote: Net driver patches should apply on top of

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-14 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 13 Sep 2007, Jeff Garzik wrote: > Net driver patches should apply on top of netdev-2.6.git#upstream, which is >

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-14 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- On Thu, 13 Sep 2007, Jeff Garzik wrote: Net driver patches should apply on top of netdev-2.6.git#upstream, which is

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Jeff Garzik
Ralf Baechle wrote: On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: Hmm, works fine with linux-2.6.git#master. I do not recall any recent activity with this driver -- I wonder what the difference is. Let me see... Hmm... HEAD du jour has no differences for the

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Ralf Baechle
On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: > Hmm, works fine with linux-2.6.git#master. I do not recall any recent > activity with this driver -- I wonder what the difference is. Let me > see... Hmm... HEAD du jour has no differences for the sb1250-mac between lmo

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Maciej W. Rozycki
On Wed, 12 Sep 2007, Jeff Garzik wrote: > > Remove typedefs, volatiles and convert kmalloc()/memset() pairs to > > kcalloc(). Also reformat the surrounding clutter. > > > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> > > --- > > ACK, but patch does not apply cleanly to

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Maciej W. Rozycki
On Wed, 12 Sep 2007, Jeff Garzik wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- ACK, but patch does not apply cleanly to netdev-2.6.git#upstream (nor

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Ralf Baechle
On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: Hmm, works fine with linux-2.6.git#master. I do not recall any recent activity with this driver -- I wonder what the difference is. Let me see... Hmm... HEAD du jour has no differences for the sb1250-mac between lmo and

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Jeff Garzik
Ralf Baechle wrote: On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: Hmm, works fine with linux-2.6.git#master. I do not recall any recent activity with this driver -- I wonder what the difference is. Let me see... Hmm... HEAD du jour has no differences for the

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-12 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse.

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-12 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse. No

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-10 Thread Ralf Baechle
On Mon, Sep 10, 2007 at 01:20:38PM +0100, Maciej W. Rozycki wrote: > Remove typedefs, volatiles and convert kmalloc()/memset() pairs to > kcalloc(). Also reformat the surrounding clutter. > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> > --- > Per your request, Andrew, a while ago.

[PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-10 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse. No semantic changes.

[PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-10 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse. No semantic changes. Please

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-10 Thread Ralf Baechle
On Mon, Sep 10, 2007 at 01:20:38PM +0100, Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Per your request, Andrew, a while ago. It