Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/08 20:51), Wanpeng Li wrote: > > 于 10/8/14, 2:43 PM, Yasuaki Ishimatsu 写道: >> While offling node by hot removing memory, the following divide error >> occurs: >> >>divide error: [#1] SMP >>[...] >>Call Trace: >> [...] handle_mm_fault >> [...] ? try_to_wake_up >>

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/09 1:54), Peter Zijlstra wrote: On Wed, Oct 08, 2014 at 12:42:24PM -0400, Rik van Riel wrote: On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: The divide error is rare case because the trigger is node offline. By this patch, when both of private and shared are set to 0, diff

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 12:42:24PM -0400, Rik van Riel wrote: > On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: > > > The divide error is rare case because the trigger is node offline. > > By this patch, when both of private and shared are set to 0, diff > > is just set to 0, not

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Rik van Riel
On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: > The divide error is rare case because the trigger is node offline. > By this patch, when both of private and shared are set to 0, diff > is just set to 0, not calculating the division. How about a simple if (private + shared) == 0)

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Wanpeng Li
于 10/8/14, 2:43 PM, Yasuaki Ishimatsu 写道: > While offling node by hot removing memory, the following divide error > occurs: > > divide error: [#1] SMP > [...] > Call Trace: >[...] handle_mm_fault >[...] ? try_to_wake_up >[...] ? wake_up_state >[...] __do_page_fault >

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:43:11PM +0900, Yasuaki Ishimatsu wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index bfa3c86..fb7dc3f 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1496,18 +1496,26 @@ static void update_task_scan_period(struct > task_struct

[PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
While offling node by hot removing memory, the following divide error occurs: divide error: [#1] SMP [...] Call Trace: [...] handle_mm_fault [...] ? try_to_wake_up [...] ? wake_up_state [...] __do_page_fault [...] ? do_futex [...] ? put_prev_entity [...] ?

[PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
While offling node by hot removing memory, the following divide error occurs: divide error: [#1] SMP [...] Call Trace: [...] handle_mm_fault [...] ? try_to_wake_up [...] ? wake_up_state [...] __do_page_fault [...] ? do_futex [...] ? put_prev_entity [...] ?

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:43:11PM +0900, Yasuaki Ishimatsu wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index bfa3c86..fb7dc3f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1496,18 +1496,26 @@ static void update_task_scan_period(struct task_struct *p,

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Wanpeng Li
于 10/8/14, 2:43 PM, Yasuaki Ishimatsu 写道: While offling node by hot removing memory, the following divide error occurs: divide error: [#1] SMP [...] Call Trace: [...] handle_mm_fault [...] ? try_to_wake_up [...] ? wake_up_state [...] __do_page_fault [...] ?

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Rik van Riel
On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: The divide error is rare case because the trigger is node offline. By this patch, when both of private and shared are set to 0, diff is just set to 0, not calculating the division. How about a simple if (private + shared) == 0)

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 12:42:24PM -0400, Rik van Riel wrote: On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: The divide error is rare case because the trigger is node offline. By this patch, when both of private and shared are set to 0, diff is just set to 0, not calculating the

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/09 1:54), Peter Zijlstra wrote: On Wed, Oct 08, 2014 at 12:42:24PM -0400, Rik van Riel wrote: On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote: The divide error is rare case because the trigger is node offline. By this patch, when both of private and shared are set to 0, diff

Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/08 20:51), Wanpeng Li wrote: 于 10/8/14, 2:43 PM, Yasuaki Ishimatsu 写道: While offling node by hot removing memory, the following divide error occurs: divide error: [#1] SMP [...] Call Trace: [...] handle_mm_fault [...] ? try_to_wake_up [...] ?