Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-15 6:49 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-15 1:54 GMT+08:00 : >>> Wanpeng Li writes: >>> 2016-07-14 1:06 GMT+08:00 : > Wanpeng Li writes:

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-15 6:49 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-15 1:54 GMT+08:00 : >>> Wanpeng Li writes: >>> 2016-07-14 1:06 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-13 1:25 GMT+08:00 : >>> Konstantin Khlebnikov writes: >>> On 11.07.2016 15:12, Xunlei

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread bsegall
Wanpeng Li writes: > 2016-07-15 1:54 GMT+08:00 : >> Wanpeng Li writes: >> >>> 2016-07-14 1:06 GMT+08:00 : Wanpeng Li writes: > 2016-07-13 1:25 GMT+08:00 :

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread bsegall
Wanpeng Li writes: > 2016-07-15 1:54 GMT+08:00 : >> Wanpeng Li writes: >> >>> 2016-07-14 1:06 GMT+08:00 : Wanpeng Li writes: > 2016-07-13 1:25 GMT+08:00 : >> Konstantin Khlebnikov writes: >> >>> On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-15 1:54 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-14 1:06 GMT+08:00 : >>> Wanpeng Li writes: >>> 2016-07-13 1:25 GMT+08:00 : > Konstantin Khlebnikov

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-15 1:54 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-14 1:06 GMT+08:00 : >>> Wanpeng Li writes: >>> 2016-07-13 1:25 GMT+08:00 : > Konstantin Khlebnikov writes: > >> On 11.07.2016 15:12, Xunlei Pang wrote: >>> On 2016/07/11 at 17:54, Wanpeng Li wrote: Hi

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread bsegall
Wanpeng Li writes: > 2016-07-14 1:06 GMT+08:00 : >> Wanpeng Li writes: >> >>> 2016-07-13 1:25 GMT+08:00 : Konstantin Khlebnikov writes: > On 11.07.2016 15:12, Xunlei

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread bsegall
Wanpeng Li writes: > 2016-07-14 1:06 GMT+08:00 : >> Wanpeng Li writes: >> >>> 2016-07-13 1:25 GMT+08:00 : Konstantin Khlebnikov writes: > On 11.07.2016 15:12, Xunlei Pang wrote: >> On 2016/07/11 at 17:54, Wanpeng Li wrote: >>> Hi Konstantin, Xunlei, >>> 2016-07-11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-14 1:06 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-13 1:25 GMT+08:00 : >>> Konstantin Khlebnikov writes: >>> On 11.07.2016 15:12, Xunlei Pang wrote: > On 2016/07/11 at 17:54, Wanpeng Li

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-14 Thread Wanpeng Li
2016-07-14 1:06 GMT+08:00 : > Wanpeng Li writes: > >> 2016-07-13 1:25 GMT+08:00 : >>> Konstantin Khlebnikov writes: >>> On 11.07.2016 15:12, Xunlei Pang wrote: > On 2016/07/11 at 17:54, Wanpeng Li wrote: >> Hi Konstantin, Xunlei, >> 2016-07-11 16:42 GMT+08:00 Xunlei Pang :

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-13 Thread bsegall
Wanpeng Li writes: > 2016-07-13 1:25 GMT+08:00 : >> Konstantin Khlebnikov writes: >> >>> On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-13 Thread bsegall
Wanpeng Li writes: > 2016-07-13 1:25 GMT+08:00 : >> Konstantin Khlebnikov writes: >> >>> On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >> On 2016/07/11 at 16:22, Xunlei Pang

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Wanpeng Li
2016-07-13 9:58 GMT+08:00 Xunlei Pang : > On 2016/07/13 at 09:50, Wanpeng Li wrote: >> 2016-07-13 1:25 GMT+08:00 : >>> Konstantin Khlebnikov writes: >>> On 11.07.2016 15:12, Xunlei Pang wrote: > On 2016/07/11 at 17:54,

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Wanpeng Li
2016-07-13 9:58 GMT+08:00 Xunlei Pang : > On 2016/07/13 at 09:50, Wanpeng Li wrote: >> 2016-07-13 1:25 GMT+08:00 : >>> Konstantin Khlebnikov writes: >>> On 11.07.2016 15:12, Xunlei Pang wrote: > On 2016/07/11 at 17:54, Wanpeng Li wrote: >> Hi Konstantin, Xunlei, >> 2016-07-11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Xunlei Pang
On 2016/07/13 at 09:50, Wanpeng Li wrote: > 2016-07-13 1:25 GMT+08:00 : >> Konstantin Khlebnikov writes: >> >>> On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Xunlei Pang
On 2016/07/13 at 09:50, Wanpeng Li wrote: > 2016-07-13 1:25 GMT+08:00 : >> Konstantin Khlebnikov writes: >> >>> On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >> On 2016/07/11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Wanpeng Li
2016-07-13 1:25 GMT+08:00 : > Konstantin Khlebnikov writes: > >> On 11.07.2016 15:12, Xunlei Pang wrote: >>> On 2016/07/11 at 17:54, Wanpeng Li wrote: Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread Wanpeng Li
2016-07-13 1:25 GMT+08:00 : > Konstantin Khlebnikov writes: > >> On 11.07.2016 15:12, Xunlei Pang wrote: >>> On 2016/07/11 at 17:54, Wanpeng Li wrote: Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : > On 2016/07/11 at 16:22, Xunlei Pang wrote: >> On 2016/07/11

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread bsegall
Konstantin Khlebnikov writes: > On 11.07.2016 15:12, Xunlei Pang wrote: >> On 2016/07/11 at 17:54, Wanpeng Li wrote: >>> Hi Konstantin, Xunlei, >>> 2016-07-11 16:42 GMT+08:00 Xunlei Pang : On 2016/07/11 at 16:22, Xunlei Pang wrote: > On

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-12 Thread bsegall
Konstantin Khlebnikov writes: > On 11.07.2016 15:12, Xunlei Pang wrote: >> On 2016/07/11 at 17:54, Wanpeng Li wrote: >>> Hi Konstantin, Xunlei, >>> 2016-07-11 16:42 GMT+08:00 Xunlei Pang : On 2016/07/11 at 16:22, Xunlei Pang wrote: > On 2016/07/11 at 15:25, Wanpeng Li wrote: >>

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Konstantin Khlebnikov
On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : On 2016/07/11 at 16:22, Xunlei Pang wrote: On 2016/07/11 at 15:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Konstantin Khlebnikov
On 11.07.2016 15:12, Xunlei Pang wrote: On 2016/07/11 at 17:54, Wanpeng Li wrote: Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : On 2016/07/11 at 16:22, Xunlei Pang wrote: On 2016/07/11 at 15:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : Hierarchy

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >> On 2016/07/11 at 16:22, Xunlei Pang wrote: >>> On 2016/07/11 at 15:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >> On 2016/07/11 at 16:22, Xunlei Pang wrote: >>> On 2016/07/11 at 15:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : > Hierarchy could be already

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Wanpeng Li
Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : > On 2016/07/11 at 16:22, Xunlei Pang wrote: >> On 2016/07/11 at 15:25, Wanpeng Li wrote: >>> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov >>> : Hierarchy could be already

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Wanpeng Li
Hi Konstantin, Xunlei, 2016-07-11 16:42 GMT+08:00 Xunlei Pang : > On 2016/07/11 at 16:22, Xunlei Pang wrote: >> On 2016/07/11 at 15:25, Wanpeng Li wrote: >>> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov >>> : Hierarchy could be already throttled at this point. Throttled next buddy

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 16:22, Xunlei Pang wrote: > On 2016/07/11 at 15:25, Wanpeng Li wrote: >> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >>> Hierarchy could be already throttled at this point. Throttled next >>> buddy could trigger null pointer dereference in

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 16:22, Xunlei Pang wrote: > On 2016/07/11 at 15:25, Wanpeng Li wrote: >> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >>> Hierarchy could be already throttled at this point. Throttled next >>> buddy could trigger null pointer dereference in pick_next_task_fair(). >> There is

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 15:25, Wanpeng Li wrote: > 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >> Hierarchy could be already throttled at this point. Throttled next >> buddy could trigger null pointer dereference in pick_next_task_fair(). > There is cfs_rq->next check in

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 15:25, Wanpeng Li wrote: > 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >> Hierarchy could be already throttled at this point. Throttled next >> buddy could trigger null pointer dereference in pick_next_task_fair(). > There is cfs_rq->next check in pick_next_entity(), so how

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Konstantin Khlebnikov
On 11.07.2016 10:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). There is cfs_rq->next check in

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Konstantin Khlebnikov
On 11.07.2016 10:25, Wanpeng Li wrote: 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). There is cfs_rq->next check in pick_next_entity(), so how can

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Wanpeng Li
2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : > Hierarchy could be already throttled at this point. Throttled next > buddy could trigger null pointer dereference in pick_next_task_fair(). There is cfs_rq->next check in pick_next_entity(), so how can null pointer

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Wanpeng Li
2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : > Hierarchy could be already throttled at this point. Throttled next > buddy could trigger null pointer dereference in pick_next_task_fair(). There is cfs_rq->next check in pick_next_entity(), so how can null pointer dereference happen? Regards,

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-21 Thread Konstantin Khlebnikov
On 16.06.2016 15:57, Konstantin Khlebnikov wrote: Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). trivial debug in set_next_buddy @@ -4755,8 +4758,11 @@ static void set_next_buddy(struct sched_entity

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-21 Thread Konstantin Khlebnikov
On 16.06.2016 15:57, Konstantin Khlebnikov wrote: Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). trivial debug in set_next_buddy @@ -4755,8 +4758,11 @@ static void set_next_buddy(struct sched_entity

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-16 Thread bsegall
Konstantin Khlebnikov writes: > Hierarchy could be already throttled at this point. Throttled next > buddy could trigger null pointer dereference in pick_next_task_fair(). > > Signed-off-by: Konstantin Khlebnikov Reviewed-by: Ben Segall

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-16 Thread bsegall
Konstantin Khlebnikov writes: > Hierarchy could be already throttled at this point. Throttled next > buddy could trigger null pointer dereference in pick_next_task_fair(). > > Signed-off-by: Konstantin Khlebnikov Reviewed-by: Ben Segall > Cc: Stable # v3.2+ > --- > kernel/sched/fair.c |

[PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-16 Thread Konstantin Khlebnikov
Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). Signed-off-by: Konstantin Khlebnikov Cc: Stable # v3.2+ --- kernel/sched/fair.c |9 - 1 file

[PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-16 Thread Konstantin Khlebnikov
Hierarchy could be already throttled at this point. Throttled next buddy could trigger null pointer dereference in pick_next_task_fair(). Signed-off-by: Konstantin Khlebnikov Cc: Stable # v3.2+ --- kernel/sched/fair.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff