Re: [PATCH] sched: cpu accounting controller (V2)

2007-12-01 Thread Balbir Singh
Paul Menage wrote: > Hi Vatsa, > > Thanks, this looks pretty good. > > On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: >> - Removed load average information. I felt it needs more thought (esp >> to deal with SMP and virtualized platforms) and can be added

Re: [PATCH] sched: cpu accounting controller (V2)

2007-12-01 Thread Balbir Singh
Paul Menage wrote: Hi Vatsa, Thanks, this looks pretty good. On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: - Removed load average information. I felt it needs more thought (esp to deal with SMP and virtualized platforms) and can be added for

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Paul Menage
Hi Vatsa, Thanks, this looks pretty good. On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > - Removed load average information. I felt it needs more thought (esp > to deal with SMP and virtualized platforms) and can be added for > 2.6.25 after

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh <[EMAIL PROTECTED]> wrote: > > thx. Have you done targeted testing of it as well? The (v2) patch is > > in sched-devel.git: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git > > Ingo > > Tested the patches on top of 2.6.24-rc3.

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> Srivatsa Vaddagiri wrote: >> [snip] >> >>> Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> >>> >> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> > > thx. Have you done targeted testing of it as well? The (v2) patch is in

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> Srivatsa Vaddagiri wrote: >> [snip] >> >>> Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> >>> >> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> > > thx. Have you done targeted testing of it as well? The (v2) patch is in

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh <[EMAIL PROTECTED]> wrote: > Srivatsa Vaddagiri wrote: > [snip] > > > Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> > > > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git:

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: > > * Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > > > > Here's V2 of the cpu acccounting controller patch, which makes > > > accounting scale better on SMP systems by splitting

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Srivatsa Vaddagiri
On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: > * Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > > Here's V2 of the cpu acccounting controller patch, which makes > > accounting scale better on SMP systems by splitting the usage counter > > to be per-cpu. > > thanks, applied.

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Srivatsa Vaddagiri wrote: [snip] > Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > Here's V2 of the cpu acccounting controller patch, which makes > accounting scale better on SMP systems by splitting the usage counter > to be per-cpu. thanks, applied. But you dont seem to have incorporated all of the review feedback from

[PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Srivatsa Vaddagiri
On Fri, Nov 30, 2007 at 01:48:33AM +0530, Srivatsa Vaddagiri wrote: > It is indeed an important todo. Right now we take a per-group global > lock on every accounting update (which can be very frequent) and hence > it is pretty bad. > > Ingo had expressed the need to reintroduce this patch asap

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh [EMAIL PROTECTED] wrote: thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git Ingo Tested the patches on top of 2.6.24-rc3. The patches work

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: * Balbir Singh [EMAIL PROTECTED] wrote: Srivatsa Vaddagiri wrote: [snip] Signed-off-by: Srivatsa Vaddagiri [EMAIL PROTECTED] Signed-off-by: Balbir Singh [EMAIL PROTECTED] thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git:

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh [EMAIL PROTECTED] wrote: Srivatsa Vaddagiri wrote: [snip] Signed-off-by: Srivatsa Vaddagiri [EMAIL PROTECTED] Signed-off-by: Balbir Singh [EMAIL PROTECTED] thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git:

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: * Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: Here's V2 of the cpu acccounting controller patch, which makes accounting scale better on SMP systems by splitting the usage

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: * Balbir Singh [EMAIL PROTECTED] wrote: Srivatsa Vaddagiri wrote: [snip] Signed-off-by: Srivatsa Vaddagiri [EMAIL PROTECTED] Signed-off-by: Balbir Singh [EMAIL PROTECTED] thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git:

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Srivatsa Vaddagiri wrote: [snip] Signed-off-by: Srivatsa Vaddagiri [EMAIL PROTECTED] Signed-off-by: Balbir Singh [EMAIL PROTECTED] -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: Here's V2 of the cpu acccounting controller patch, which makes accounting scale better on SMP systems by splitting the usage counter to be per-cpu. thanks, applied. But you dont seem to have incorporated all of the review feedback from Andrew.

[PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Srivatsa Vaddagiri
On Fri, Nov 30, 2007 at 01:48:33AM +0530, Srivatsa Vaddagiri wrote: It is indeed an important todo. Right now we take a per-group global lock on every accounting update (which can be very frequent) and hence it is pretty bad. Ingo had expressed the need to reintroduce this patch asap and

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Srivatsa Vaddagiri
On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: * Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: Here's V2 of the cpu acccounting controller patch, which makes accounting scale better on SMP systems by splitting the usage counter to be per-cpu. thanks, applied. But you dont

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Paul Menage
Hi Vatsa, Thanks, this looks pretty good. On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: - Removed load average information. I felt it needs more thought (esp to deal with SMP and virtualized platforms) and can be added for 2.6.25 after more