Re: [PATCH] sched: fix group_entity's share update

2016-12-19 Thread Vincent Guittot
On 16 December 2016 at 09:55, Vincent Guittot wrote: > On 15 December 2016 at 22:42, Peter Zijlstra wrote: >> >> On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: >> > The update of the share of a cfs_rq is done when its load_avg

Re: [PATCH] sched: fix group_entity's share update

2016-12-19 Thread Vincent Guittot
On 16 December 2016 at 09:55, Vincent Guittot wrote: > On 15 December 2016 at 22:42, Peter Zijlstra wrote: >> >> On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: >> > The update of the share of a cfs_rq is done when its load_avg is updated >> > but before the group_entity's

Re: [PATCH] sched: fix group_entity's share update

2016-12-16 Thread Vincent Guittot
On 15 December 2016 at 22:42, Peter Zijlstra wrote: > > On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: > > The update of the share of a cfs_rq is done when its load_avg is updated > > but before the group_entity's load_avg has been updated for the past time

Re: [PATCH] sched: fix group_entity's share update

2016-12-16 Thread Vincent Guittot
On 15 December 2016 at 22:42, Peter Zijlstra wrote: > > On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: > > The update of the share of a cfs_rq is done when its load_avg is updated > > but before the group_entity's load_avg has been updated for the past time > > slot. This

Re: [PATCH] sched: fix group_entity's share update

2016-12-15 Thread Peter Zijlstra
On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: > The update of the share of a cfs_rq is done when its load_avg is updated > but before the group_entity's load_avg has been updated for the past time > slot. This generates wrong load_avg accounting which can be significant > when

Re: [PATCH] sched: fix group_entity's share update

2016-12-15 Thread Peter Zijlstra
On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: > The update of the share of a cfs_rq is done when its load_avg is updated > but before the group_entity's load_avg has been updated for the past time > slot. This generates wrong load_avg accounting which can be significant > when

Re: [PATCH] sched: fix group_entity's share update

2016-12-15 Thread Vincent Guittot
Gentle ping ... Vincent On 1 December 2016 at 17:38, Vincent Guittot wrote: > The update of the share of a cfs_rq is done when its load_avg is updated > but before the group_entity's load_avg has been updated for the past time > slot. This generates wrong load_avg

Re: [PATCH] sched: fix group_entity's share update

2016-12-15 Thread Vincent Guittot
Gentle ping ... Vincent On 1 December 2016 at 17:38, Vincent Guittot wrote: > The update of the share of a cfs_rq is done when its load_avg is updated > but before the group_entity's load_avg has been updated for the past time > slot. This generates wrong load_avg accounting which can be

[PATCH] sched: fix group_entity's share update

2016-12-01 Thread Vincent Guittot
The update of the share of a cfs_rq is done when its load_avg is updated but before the group_entity's load_avg has been updated for the past time slot. This generates wrong load_avg accounting which can be significant when small tasks are involved in the scheduling. Let take the example of a

[PATCH] sched: fix group_entity's share update

2016-12-01 Thread Vincent Guittot
The update of the share of a cfs_rq is done when its load_avg is updated but before the group_entity's load_avg has been updated for the past time slot. This generates wrong load_avg accounting which can be significant when small tasks are involved in the scheduling. Let take the example of a