On Fri, Dec 04, 2020 at 10:08:08AM +1100, Finn Thain wrote:
...
>
> You've put your finger on a known problem with certain
> NCR5380_poll_politely() call sites. That is, the nominal timeout, HZ / 64,
> is meaningless because it is ignored in atomic context. So you may as well
> specify 0 jiffies
Hi Finn,
On Fri, Dec 4, 2020 at 12:11 AM Finn Thain wrote:
> > --- a/drivers/scsi/g_NCR5380.c
> > +++ b/drivers/scsi/g_NCR5380.c
> > @@ -529,14 +529,14 @@ static inline int generic_NCR5380_precv(struct
> > NCR5380_hostdata *hostdata,
> > if (start == len - 128) {
> >
136046n Tue, 1 Dec 2020, Sebastian Andrzej Siewior wrote:
> On 2020-12-01 17:46:36 [+1100], Finn Thain wrote:
> > The in_interrupt() macro is deprecated. Also, it's usage in
> > NCR5380_poll_politely2() has long been redundant.
>
> So you rely on the assumption that interrupts are always
Hi Finn,
works fine, thanks!
Tested-By: Michael Schmitz
On 1/12/20 7:46 PM, Finn Thain wrote:
The in_interrupt() macro is deprecated. Also, it's usage in
NCR5380_poll_politely2() has long been redundant.
Cc: Sebastian Andrzej Siewior
Cc: Ahmed S. Darwish
Cc: Thomas Gleixner
Link:
On 2020-12-01 17:46:36 [+1100], Finn Thain wrote:
> The in_interrupt() macro is deprecated. Also, it's usage in
> NCR5380_poll_politely2() has long been redundant.
So you rely on the assumption that interrupts are always disabled. Hmmm.
You complained about the additional argument and that things
The in_interrupt() macro is deprecated. Also, it's usage in
NCR5380_poll_politely2() has long been redundant.
Cc: Sebastian Andrzej Siewior
Cc: Ahmed S. Darwish
Cc: Thomas Gleixner
Link: https://lore.kernel.org/r/20201126132952.2287996-1-bige...@linutronix.de
Signed-off-by: Finn Thain
---
6 matches
Mail list logo
