Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 18 Jan 2021 16:08:12 +0100 you wrote: > sh_eth_close() does a synchronous power down of the device before > marking it closed. Revert the order, to make sure the device is never > marked opened while suspended. > > Whi

Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Niklas Söderlund
Hi Geert, Thanks for your work. On 2021-01-18 16:08:12 +0100, Geert Uytterhoeven wrote: > sh_eth_close() does a synchronous power down of the device before > marking it closed. Revert the order, to make sure the device is never > marked opened while suspended. > > While at it, use pm_runtime_pu

Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Sergei Shtylyov
On 1/18/21 6:08 PM, Geert Uytterhoeven wrote: > sh_eth_close() does a synchronous power down of the device before > marking it closed. Revert the order, to make sure the device is never > marked opened while suspended. > > While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as >

[PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Geert Uytterhoeven
sh_eth_close() does a synchronous power down of the device before marking it closed. Revert the order, to make sure the device is never marked opened while suspended. While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as there is no reason to do a synchronous power down. Fixes: