Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Christoph Lameter
On Fri, 23 Mar 2007, Andy Whitcroft wrote: > > + /* > > +* We put nodelists[] at the end of kmem_cache, because we want to size > > +* this array to nr_node_ids slots instead of MAX_NUMNODES > > +* (see kmem_cache_init()) > > +* We still use [MAX_NUMNODES] and not [1] or [0]

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Andy Whitcroft
Eric Dumazet wrote: > Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer > possible nodes. This patch dynamically sizes the 'struct kmem_cache' to > allocate only needed space. > > I moved nodelists[] field at the end of struct kmem_cache, and use the > following computation in

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Eric Dumazet
Pekka J Enberg a écrit : (Please inline patches to the mail, makes it easier to review.) On Thu, 22 Mar 2007, Eric Dumazet wrote: Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Pekka J Enberg
(Please inline patches to the mail, makes it easier to review.) On Thu, 22 Mar 2007, Eric Dumazet wrote: > Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible > nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only > needed space. > > I moved

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Pekka J Enberg
(Please inline patches to the mail, makes it easier to review.) On Thu, 22 Mar 2007, Eric Dumazet wrote: Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed space. I moved

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Eric Dumazet
Pekka J Enberg a écrit : (Please inline patches to the mail, makes it easier to review.) On Thu, 22 Mar 2007, Eric Dumazet wrote: Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Andy Whitcroft
Eric Dumazet wrote: Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed space. I moved nodelists[] field at the end of struct kmem_cache, and use the following computation in

Re: [PATCH] slab: NUMA kmem_cache diet

2007-03-23 Thread Christoph Lameter
On Fri, 23 Mar 2007, Andy Whitcroft wrote: + /* +* We put nodelists[] at the end of kmem_cache, because we want to size +* this array to nr_node_ids slots instead of MAX_NUMNODES +* (see kmem_cache_init()) +* We still use [MAX_NUMNODES] and not [1] or [0] because

[PATCH] slab: NUMA kmem_cache diet

2007-03-22 Thread Eric Dumazet
Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed space. I moved nodelists[] field at the end of struct kmem_cache, and use the following computation in kmem_cache_init()

[PATCH] slab: NUMA kmem_cache diet

2007-03-22 Thread Eric Dumazet
Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer possible nodes. This patch dynamically sizes the 'struct kmem_cache' to allocate only needed space. I moved nodelists[] field at the end of struct kmem_cache, and use the following computation in kmem_cache_init()