Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-08 Thread Tobin C. Harding
On Sun, Apr 07, 2019 at 07:35:34PM -1000, Linus Torvalds wrote: > On Sat, Apr 6, 2019 at 12:59 PM Qian Cai wrote: > > > > The commit 510ded33e075 ("slab: implement slab_root_caches list") > > changes the name of the list node within "struct kmem_cache" from > > "list" to "root_caches_node", but

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-08 Thread Christopher Lameter
On Sun, 7 Apr 2019, Linus Torvalds wrote: > On Sat, Apr 6, 2019 at 12:59 PM Qian Cai wrote: > > > > The commit 510ded33e075 ("slab: implement slab_root_caches list") > > changes the name of the list node within "struct kmem_cache" from > > "list" to "root_caches_node", but leaks_show() still use

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-08 Thread Qian Cai
On Sun, 2019-04-07 at 19:35 -1000, Linus Torvalds wrote: > On Sat, Apr 6, 2019 at 12:59 PM Qian Cai wrote: > > > > The commit 510ded33e075 ("slab: implement slab_root_caches list") > > changes the name of the list node within "struct kmem_cache" from > > "list" to "root_caches_node", but

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-07 Thread Linus Torvalds
On Sat, Apr 6, 2019 at 12:59 PM Qian Cai wrote: > > The commit 510ded33e075 ("slab: implement slab_root_caches list") > changes the name of the list node within "struct kmem_cache" from > "list" to "root_caches_node", but leaks_show() still use the "list" > which causes a crash when reading

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-07 Thread Tobin C. Harding
On Sat, Apr 06, 2019 at 06:59:01PM -0400, Qian Cai wrote: > The commit 510ded33e075 ("slab: implement slab_root_caches list") > changes the name of the list node within "struct kmem_cache" from > "list" to "root_caches_node", but leaks_show() still use the "list" > which causes a crash when

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-07 Thread Qian Cai
On 4/7/19 9:59 PM, Tobin C. Harding wrote: > On Sat, Apr 06, 2019 at 06:59:01PM -0400, Qian Cai wrote: >> The commit 510ded33e075 ("slab: implement slab_root_caches list") >> changes the name of the list node within "struct kmem_cache" from >> "list" to "root_caches_node" > > Are you sure? It

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-07 Thread Tobin C. Harding
On Sat, Apr 06, 2019 at 06:59:01PM -0400, Qian Cai wrote: > The commit 510ded33e075 ("slab: implement slab_root_caches list") > changes the name of the list node within "struct kmem_cache" from > "list" to "root_caches_node" Are you sure? It looks to me like it adds a member to the

[PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-06 Thread Qian Cai
The commit 510ded33e075 ("slab: implement slab_root_caches list") changes the name of the list node within "struct kmem_cache" from "list" to "root_caches_node", but leaks_show() still use the "list" which causes a crash when reading /proc/slab_allocators. BUG: unable to handle kernel NULL