Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-27 Thread kbuild test robot
Hi Tommy, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170627] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-27 Thread kbuild test robot
Hi Tommy, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170627] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead. Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by:

Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead. Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by:

[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Tommy Nguyen
Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE and debugfs_create_file_unsafe should be used instead. Signed-off-by: Tommy Nguyen --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Tommy Nguyen
Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE and debugfs_create_file_unsafe should be used instead. Signed-off-by: Tommy Nguyen --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c