Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote: > On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote: > > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: [] > > > Here is another version with macro expansion. Inline function > > > expansion doesn't > > > seem like a

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote: > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: > > This patch fixes the checkpatch.pl error: > > > > ERROR: Macros with complex values should be enclosed in parentheses > > +#define CONSUME(val, ptr) (val) =

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote: On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val),

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote: On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote: On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: [] Here is another version with macro expansion. Inline function expansion doesn't seem like a good idea

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: > This patch fixes the checkpatch.pl error: > > ERROR: Macros with complex values should be enclosed in parentheses > +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > > by expanding it as this macro is used only once. []

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) by expanding it as this macro is used only once. []

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) by expanding it as this macro is used only once. Signed-off-by: Vasiliy Korchagin --- Notes: Here is another version

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote: > This patch fixes the checkpatch.pl error: > > ERROR: Macros with complex values should be enclosed in parentheses > +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > > Signed-off-by: Vasiliy Korchagin > --- >

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) Signed-off-by: Vasiliy Korchagin --- drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +- 1 file changed, 1

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) Signed-off-by: Vasiliy Korchagin vasiliy.korcha...@gmail.com --- drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +- 1

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote: This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) Signed-off-by: Vasiliy Korchagin

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) by expanding it as this macro is used only once. Signed-off-by: Vasiliy Korchagin vasiliy.korcha...@gmail.com --- Notes: