Re: [PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

2017-12-04 Thread Dan Carpenter
The subject is way too long. On Mon, Dec 04, 2017 at 08:18:51PM +0200, Marcus Wolf wrote: > To increase the readability of the register accesses, the abstraction > of the helpers was increased from simple read and write to set bit, > reset bit and read modify write bit. In addition - according to

Re: [PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

2017-12-04 Thread Dan Carpenter
The subject is way too long. On Mon, Dec 04, 2017 at 08:18:51PM +0200, Marcus Wolf wrote: > To increase the readability of the register accesses, the abstraction > of the helpers was increased from simple read and write to set bit, > reset bit and read modify write bit. In addition - according to

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

2017-12-04 Thread Marcus Wolf
To increase the readability of the register accesses, the abstraction of the helpers was increased from simple read and write to set bit, reset bit and read modify write bit. In addition - according to the proposal from Walter Harms from 20.07.2017 - instead of marcros inline functions were used.

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

2017-12-04 Thread Marcus Wolf
To increase the readability of the register accesses, the abstraction of the helpers was increased from simple read and write to set bit, reset bit and read modify write bit. In addition - according to the proposal from Walter Harms from 20.07.2017 - instead of marcros inline functions were used.