Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-20 Thread Nick Krause
This patch is old I thought I fixed it and resent. Cheers Nick On Thu, Jun 19, 2014 at 5:25 PM, Joe Perches wrote: > On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote: > >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c >> b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmw

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote: > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c [] > @@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 > *code_virtual_address, >

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nicholas Krause
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 --- a/drivers/staging/rtl8192e/

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nick Krause
Hey guys, Sorry about no reply, my power supply died last night, have to get a new one. I will be RMAing the old old in order to get a packup in case this PSU dies. Cheers Nick On Thu, Jun 19, 2014 at 1:29 AM, Dan Carpenter wrote: > On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrot

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Dan Carpenter
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: > Checks if dev_skb_alloc returns Null in function, fw_download_code. > If the return value of dev_skb_alloc is NULL return false and exit > this function. > Signed-off-by: Nicholas Krause > --- > drivers/staging/rtl8192e/rtl8192e/r

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Joe Perches
On Wed, 2014-06-18 at 22:24 -0400, Nicholas Krause wrote: > Checks if dev_skb_alloc returns Null in function, fw_download_code. > If the return value of dev_skb_alloc is NULL return false and exit > this function. Hello Nicholas. If you're going to try add these checks, please look at the code a

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: > Checks if dev_skb_alloc returns Null in function, fw_download_code. > If the return value of dev_skb_alloc is NULL return false and exit > this function. > Signed-off-by: Nicholas Krause > --- > drivers/staging/rtl8192e/rtl8192e/r

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver