On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
> On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> > On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
> []
> > > Is it ok to keep these codes and add comments like:
>
> It's your code Yu, do whatever you think
On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
[]
Is it ok to keep these codes and add comments like:
It's your code Yu, do whatever you think appropriate.
Hi, Darren and Joe,
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
>
> The commentary is useful regardless. However, I suspect Joe was
> referring to the approach pairing the PRESS and RELEASE cases?
>
I've wrote another piece
Hi, Darren and Joe,
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
The commentary is useful regardless. However, I suspect Joe was
referring to the approach pairing the PRESS and RELEASE cases?
I've wrote another piece of
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
[]
> > Is it ok to keep these codes and add comments like:
It's your code Yu, do whatever you think appropriate.
> > /*
> > * When a button(power button/volume button/home button)
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
> Thanks Joe,
> On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
> > On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
> > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> > > Guide for SoC Platform", code in
On Thu, 2015-08-06 at 11:20 +, Chen, Yu C wrote:
> On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
[]
> > > + case SURFACE_BUTTON_NOTIFY_PRESS_HOME:
> > > + pressed = true;
> > > + case SURFACE_BUTTON_NOTIFY_RELEASE_HOME:
> > > + key_code = KEY_LEFTMETA;
> > > +
Thanks Joe,
On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
> On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
> > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> > not detect these buttons on
Thanks Joe,
On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
Since Surface Pro 3 does not follow the specs of Windows ACPI Design
Guide for SoC Platform, code in drivers/input/misc/soc_array.c can
not detect these buttons on it.
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
[]
Is it ok to keep these codes and add comments like:
It's your code Yu, do whatever you think appropriate.
/*
* When a button(power button/volume button/home button) is
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
Thanks Joe,
On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
Since Surface Pro 3 does not follow the specs of Windows ACPI Design
Guide for SoC Platform, code in
On Thu, 2015-08-06 at 11:20 +, Chen, Yu C wrote:
On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
[]
+ case SURFACE_BUTTON_NOTIFY_PRESS_HOME:
+ pressed = true;
+ case SURFACE_BUTTON_NOTIFY_RELEASE_HOME:
+ key_code = KEY_LEFTMETA;
+ break;
It
On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
> Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> not detect these buttons on it.
style trivia:
> diff --git a/drivers/platform/x86/surfacepro3_button.c
Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
not detect these buttons on it. According to bios implementation,
Surface Pro 3 encapsulates these buttons in a device named "VGBI",
with _HID "MSHW0028". When
On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote:
Since Surface Pro 3 does not follow the specs of Windows ACPI Design
Guide for SoC Platform, code in drivers/input/misc/soc_array.c can
not detect these buttons on it.
style trivia:
diff --git a/drivers/platform/x86/surfacepro3_button.c
Since Surface Pro 3 does not follow the specs of Windows ACPI Design
Guide for SoC Platform, code in drivers/input/misc/soc_array.c can
not detect these buttons on it. According to bios implementation,
Surface Pro 3 encapsulates these buttons in a device named VGBI,
with _HID MSHW0028. When any of
16 matches
Mail list logo
