Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread Takashi Iwai
At Thu, 13 Feb 2014 19:02:46 +0100, rauchwo...@gmx.net wrote: > > Hi, > > this patch doesn't work. The sound is now muted after the resume (light is > on). > But the userspace knows nothing about it. (kmix shows the volume as umuted) OK, scratch the last patch. I thought the mute LED is also

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread rauchwolke
Hi, this patch doesn't work. The sound is now muted after the resume (light is on). But the userspace knows nothing about it. (kmix shows the volume as umuted) Peter On Thu, 13 Feb 2014 09:35:30 +0100 Takashi Iwai wrote: > At Wed, 12 Feb 2014 20:37:36 +, > Matthew Garrett wrote: > > >

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread Takashi Iwai
At Wed, 12 Feb 2014 20:37:36 +, Matthew Garrett wrote: > > On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > > The mute LED states have to be restored after resume. > > Oh, never mind, we're not doing this through the LED class, are we? Good point. It seems that leds_class has

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread Takashi Iwai
At Wed, 12 Feb 2014 20:37:36 +, Matthew Garrett wrote: On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: The mute LED states have to be restored after resume. Oh, never mind, we're not doing this through the LED class, are we? Good point. It seems that leds_class has pm_ops but

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread rauchwolke
Hi, this patch doesn't work. The sound is now muted after the resume (light is on). But the userspace knows nothing about it. (kmix shows the volume as umuted) Peter On Thu, 13 Feb 2014 09:35:30 +0100 Takashi Iwai ti...@suse.de wrote: At Wed, 12 Feb 2014 20:37:36 +, Matthew Garrett

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-13 Thread Takashi Iwai
At Thu, 13 Feb 2014 19:02:46 +0100, rauchwo...@gmx.net wrote: Hi, this patch doesn't work. The sound is now muted after the resume (light is on). But the userspace knows nothing about it. (kmix shows the volume as umuted) OK, scratch the last patch. I thought the mute LED is also a

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > The mute LED states have to be restored after resume. Oh, never mind, we're not doing this through the LED class, are we? -- Matthew Garrett N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z�

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > The mute LED states have to be restored after resume. Hm. Is this something that should be done in the class code rather than in individual drivers? -- Matthew Garrett

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Henrique de Moraes Holschuh
On Wed, Feb 12, 2014, at 13:32, Takashi Iwai wrote: > The mute LED states have to be restored after resume. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70351 > Cc: [v3.13+] > Signed-off-by: Takashi Iwai Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One

[PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Takashi Iwai
The mute LED states have to be restored after resume. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70351 Cc: [v3.13+] Signed-off-by: Takashi Iwai --- drivers/platform/x86/thinkpad_acpi.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Takashi Iwai
The mute LED states have to be restored after resume. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70351 Cc: sta...@vger.kernel.org [v3.13+] Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/platform/x86/thinkpad_acpi.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Henrique de Moraes Holschuh
On Wed, Feb 12, 2014, at 13:32, Takashi Iwai wrote: The mute LED states have to be restored after resume. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70351 Cc: sta...@vger.kernel.org [v3.13+] Signed-off-by: Takashi Iwai ti...@suse.de Acked-by: Henrique de Moraes Holschuh

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: The mute LED states have to be restored after resume. Hm. Is this something that should be done in the class code rather than in individual drivers? -- Matthew Garrett matthew.garr...@nebula.com

Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

2014-02-12 Thread Matthew Garrett
On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: The mute LED states have to be restored after resume. Oh, never mind, we're not doing this through the LED class, are we? -- Matthew Garrett matthew.garr...@nebula.com