On Fri, Aug 31, 2007 at 02:53:23PM +0100, Christoph Hellwig wrote:
> On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
> > "those callers". There was _exactly one_ caller, and that was an out-of-tree
> > module. There were not any in-kernel callers before, and it did not generate
> >
On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
> "those callers". There was _exactly one_ caller, and that was an out-of-tree
> module. There were not any in-kernel callers before, and it did not generate
> any warning. That is perhaps why no one had constified it before me. This
On Fri, Aug 31, 2007 at 02:53:23PM +0100, Christoph Hellwig wrote:
On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
those callers. There was _exactly one_ caller, and that was an out-of-tree
module. There were not any in-kernel callers before, and it did not generate
any
On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
those callers. There was _exactly one_ caller, and that was an out-of-tree
module. There were not any in-kernel callers before, and it did not generate
any warning. That is perhaps why no one had constified it before me. This does
On Thu, 30 Aug 2007, Jan Engelhardt wrote:
>
> On Aug 31 2007 02:11, Satyam Sharma wrote:
> >> So that you can actually pass in a const struct task_struct * without
> >> having
> >> to cast it back to [non-const].
> >
> >... which makes zero sense, because ...
> >
> >> Why one would have a
On Aug 31 2007 02:11, Satyam Sharma wrote:
>> So that you can actually pass in a const struct task_struct * without having
>> to cast it back to [non-const].
>
>... which makes zero sense, because ...
>
>> Why one would have a const struct task_struct * in the first place
>> is a different
On Thu, 30 Aug 2007, Jan Engelhardt wrote:
>
> On Aug 28 2007 01:33, Alexey Dobriyan wrote:
> >
> >On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
> >> Add const to some struct task_struct * uses
> >
> >Why, oh, why?
>
>
> So that you can actually pass in a const struct
On Aug 28 2007 01:33, Alexey Dobriyan wrote:
>
>On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
>> Add const to some struct task_struct * uses
>
>Why, oh, why?
So that you can actually pass in a const struct task_struct * without having
to cast it back to [non-const].
Why one
On Aug 28 2007 01:33, Alexey Dobriyan wrote:
On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
Add const to some struct task_struct * uses
Why, oh, why?
So that you can actually pass in a const struct task_struct * without having
to cast it back to [non-const].
Why one would have
On Thu, 30 Aug 2007, Jan Engelhardt wrote:
On Aug 28 2007 01:33, Alexey Dobriyan wrote:
On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
Add const to some struct task_struct * uses
Why, oh, why?
So that you can actually pass in a const struct task_struct * without
On Aug 31 2007 02:11, Satyam Sharma wrote:
So that you can actually pass in a const struct task_struct * without having
to cast it back to [non-const].
... which makes zero sense, because ...
Why one would have a const struct task_struct * in the first place
is a different matter.
...
On Thu, 30 Aug 2007, Jan Engelhardt wrote:
On Aug 31 2007 02:11, Satyam Sharma wrote:
So that you can actually pass in a const struct task_struct * without
having
to cast it back to [non-const].
... which makes zero sense, because ...
Why one would have a const struct
On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
> Add const to some struct task_struct * uses
Why, oh, why? This way code there are more characters on screen and zero
change in vmlinux, at least here.
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1222,22 +1222,22
Joe Perches napsal(a):
> Add const to some struct task_struct * uses
Does this have any impact on generated code? What (some objdumps or something)?
Or more descriptive log, why is this about to be done, please.
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
> ---
>
>
Add const to some struct task_struct * uses
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
include/linux/sched.h | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index ba78807..71d40a1 100644
---
Add const to some struct task_struct * uses
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
include/linux/sched.h | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index ba78807..71d40a1 100644
---
Joe Perches napsal(a):
Add const to some struct task_struct * uses
Does this have any impact on generated code? What (some objdumps or something)?
Or more descriptive log, why is this about to be done, please.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
include/linux/sched.h |
On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote:
Add const to some struct task_struct * uses
Why, oh, why? This way code there are more characters on screen and zero
change in vmlinux, at least here.
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1222,22 +1222,22 @@
18 matches
Mail list logo