Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote:

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: > On 2021/3/3 4:29 下午, Cornelia Huck wrote: > > On Wed, 3 Mar 2021 12:01:01 +0800 > > Jason Wang wrote: > > > >> On 2021/3/2 8:08 下午, Cornelia Huck wrote: > >>> On Mon, 1 Mar 2021 11:51:08 +0800 > >>> Jason Wang wrote: > >>> >

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: > On 2021/3/2 8:08 下午, Cornelia Huck wrote: > > On Mon, 1 Mar 2021 11:51:08 +0800 > > Jason Wang wrote: > > > >> On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: > >>> On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: > On

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: > On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: > > On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: > >> On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: > >>> Confused. What is wrong with the above? It never reads the > >>>

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify the

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: > > On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: > > > > Detecting it isn't enough though, we will need a new ioctl to notify > > > > the kernel that it's a legacy guest.

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2/28/2021 1:27 PM, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote: Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify the kernel that it's a legacy guest. Ugh :( Well, although I think adding an ioctl is doable, may I know what the

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/1 5:30 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 05:30:37PM +0800, Jason Wang wrote: On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: > > Detecting it isn't enough though, we will need a new ioctl to notify > > the kernel that it's a legacy guest. Ugh :( > Well, although I think adding an ioctl is doable, may I know what the use > case there will be for kernel to

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 05:30:37PM +0800, Jason Wang wrote: > > On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: > > > Basically on first guest access QEMU would tell kernel whether > > > guest is using the legacy or the

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: > > > On 2/23/2021 9:04 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote: > > Hi Michael, > > Are you okay to live without this ioctl for now? I think QEMU is the one > that needs to be fixed and will have to be made legacy guest aware. I think > the kernel can just honor the feature negotiation result done

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: > > On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: > > On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: > > > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > > > On Wed, 24 Feb 2021 17:29:07 +0800 > > > > Jason Wang wrote: >

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just honor the feature negotiation result done by QEMU and do as what's told to.Will you agree? If it's fine, I

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: > > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > > > On 2021/2/23 6:58 下午, Cornelia Huck wrote: > > > > On Tue, 23 Feb 2021 18:31:07 +0800 > > > > Jason Wang wrote: > >

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Thu, 25 Feb 2021 12:36:07 +0800 Jason Wang wrote: > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > >> On 2021/2/23 6:58 下午, Cornelia Huck wrote: > >>> On Tue, 23 Feb 2021 18:31:07 +0800 > >>> Jason Wang wrote: > The

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2/23/2021 9:04 PM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 02:12:01AM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote: > > > > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: > > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > > > > On Wed, Feb 24, 2021 at 12:17:58AM

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: > On 2021/2/23 6:58 下午, Cornelia Huck wrote: > > On Tue, 23 Feb 2021 18:31:07 +0800 > > Jason Wang wrote: > > > >> On 2021/2/23 6:04 下午, Cornelia Huck wrote: > >>> On Tue, 23 Feb 2021 17:46:20 +0800 > >>> Jason Wang wrote: > >>> >

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 6:17 下午, Jason Wang wrote: On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether guest is using the legacy or the modern interface. E.g. virtio_pci_config_read/virtio_pci_config_write will

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: > Basically on first guest access QEMU would tell kernel whether > guest is using the legacy or the modern interface. > E.g. virtio_pci_config_read/virtio_pci_config_write will call > ioctl(ENABLE_LEGACY, 1) > while

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 02:53:08PM +0800, Jason Wang wrote: > > On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: > > > On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote:

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote: > > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > > > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Feb 24, 2021 at 11:20:01AM

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote: > > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > > > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Feb 24, 2021 at 11:20:01AM

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > > > > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > > > > > > > On 2/23/2021 5:26 AM,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: > > On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S.

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 1:17 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: > > > > On 2021/2/23 9:12 上午, Si-Wei Liu wrote: > > > > > > > >

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: > > > On 2021/2/23 9:12 上午, Si-Wei Liu wrote: > > > > > > > > On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: > > >

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: > > On 2021/2/23 9:12 上午, Si-Wei Liu wrote: > > > > > > On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: > > > On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: > > > > On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > > > > > Commit

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > for legacy") made an exception for legacy guests to reset > features to 0, when config space is accessed before features > are set. We should relieve the

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: > On 2021/2/23 6:04 下午, Cornelia Huck wrote: > > On Tue, 23 Feb 2021 17:46:20 +0800 > > Jason Wang wrote: > > > >> On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: > >>> On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: >

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote:

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: > On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: > > On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: > >> > >> On 2/21/2021 8:14 PM, Jason Wang wrote: > >>> On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > Commit 452639a64ad8

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: > > On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: > > On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: > > > > > > On 2/21/2021 8:14 PM, Jason Wang wrote: > > > > On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > > > > > Commit

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Tue, Feb 23, 2021 at 05:48:10PM +0800, Jason Wang wrote: > > On 2021/2/23 下午5:26, Michael S. Tsirkin wrote: > > On Mon, Feb 22, 2021 at 08:05:26AM +0200, Eli Cohen wrote: > > > On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: > > > > On Sun, Feb 21, 2021 at 04:44:37PM +0200,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 下午5:26, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 08:05:26AM +0200, Eli Cohen wrote: On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Mon, Feb 22, 2021 at 08:05:26AM +0200, Eli Cohen wrote: > On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: > > On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > > > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > > > Commit 452639a64ad8 ("vdpa: make

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: > > > On 2/21/2021 8:14 PM, Jason Wang wrote: > > > > On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > > for legacy") made an exception for legacy guests to reset > > >

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/23 1:09 上午, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed before features are set. We should relieve the

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: > > On 2021/2/19 7:54 下午, Si-Wei Liu wrote: > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > for legacy") made an exception for legacy guests to reset > > features to 0, when config space is accessed before features

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: > On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > > for legacy") made an exception

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed before features are set. We should relieve the verify_min_features() check and allow

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > for legacy") made an exception for legacy guests to reset > > features to 0, when config space is accessed

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > for legacy") made an exception for legacy guests to reset > features to 0, when config space is accessed before features > are set. We should relieve the

[PATCH] vdpa/mlx5: set_features should allow reset to zero

Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed before features are set. We should relieve the verify_min_features() check and allow features reset to 0 for this case. It's worth