Re: [PATCH] vfio/type1: Fix unmap overflow off-by-one

2019-01-09 Thread Cornelia Huck
On Tue, 08 Jan 2019 09:40:06 -0700 Alex Williamson wrote: > The below referenced commit adds a test for integer overflow, but in > doing so prevents the unmap ioctl from ever including the last page of > the address space. Subtract one to compare to the last address of the > unmap to avoid the

Re: [PATCH] vfio/type1: Fix unmap overflow off-by-one

2019-01-08 Thread Peter Xu
On Tue, Jan 08, 2019 at 09:40:06AM -0700, Alex Williamson wrote: > The below referenced commit adds a test for integer overflow, but in > doing so prevents the unmap ioctl from ever including the last page of > the address space. Subtract one to compare to the last address of the > unmap to avoid

Re: [PATCH] vfio/type1: Fix unmap overflow off-by-one

2019-01-08 Thread Dan Carpenter
Yeah, sorry about that. Reviewed-by: Dan Carpenter regards, dan carpenter

[PATCH] vfio/type1: Fix unmap overflow off-by-one

2019-01-08 Thread Alex Williamson
The below referenced commit adds a test for integer overflow, but in doing so prevents the unmap ioctl from ever including the last page of the address space. Subtract one to compare to the last address of the unmap to avoid the overflow and wrap-around. Fixes: 71a7d3d78e3c ("vfio/type1: silence