Re: [PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Vivek Goyal
On Wed, Dec 16, 2020 at 10:53:16AM -0500, Jeff Layton wrote: > On Wed, 2020-12-16 at 10:44 -0500, Jeff Layton wrote: > > On Wed, 2020-12-16 at 10:14 -0500, Vivek Goyal wrote: > > > On Wed, Dec 16, 2020 at 09:57:49AM -0500, Jeff Layton wrote: > > > > On Wed, 2020-12-16 at 09:38 -0500, Vivek Goyal

Re: [PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Jeff Layton
On Wed, 2020-12-16 at 10:44 -0500, Jeff Layton wrote: > On Wed, 2020-12-16 at 10:14 -0500, Vivek Goyal wrote: > > On Wed, Dec 16, 2020 at 09:57:49AM -0500, Jeff Layton wrote: > > > On Wed, 2020-12-16 at 09:38 -0500, Vivek Goyal wrote: > > > > I see that current implementation of

Re: [PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Jeff Layton
On Wed, 2020-12-16 at 10:14 -0500, Vivek Goyal wrote: > On Wed, Dec 16, 2020 at 09:57:49AM -0500, Jeff Layton wrote: > > On Wed, 2020-12-16 at 09:38 -0500, Vivek Goyal wrote: > > > I see that current implementation of __sync_filesystem() ignores the > > > return code from ->sync_fs(). I am not

Re: [PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Vivek Goyal
On Wed, Dec 16, 2020 at 09:57:49AM -0500, Jeff Layton wrote: > On Wed, 2020-12-16 at 09:38 -0500, Vivek Goyal wrote: > > I see that current implementation of __sync_filesystem() ignores the > > return code from ->sync_fs(). I am not sure why that's the case. > > > > Ignoring ->sync_fs() return

Re: [PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Jeff Layton
On Wed, 2020-12-16 at 09:38 -0500, Vivek Goyal wrote: > I see that current implementation of __sync_filesystem() ignores the > return code from ->sync_fs(). I am not sure why that's the case. > > Ignoring ->sync_fs() return code is problematic for overlayfs where > it can return error if

[PATCH] vfs, syncfs: Do not ignore return code from ->sync_fs()

2020-12-16 Thread Vivek Goyal
I see that current implementation of __sync_filesystem() ignores the return code from ->sync_fs(). I am not sure why that's the case. Ignoring ->sync_fs() return code is problematic for overlayfs where it can return error if sync_filesystem() on upper super block failed. That error will simply be