Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 11:35 AM, Sasha Levin wrote: > On 11/21/2012 02:24 PM, H. Peter Anvin wrote: >> On 11/21/2012 11:19 AM, Sasha Levin wrote: So, are there any mptables platforms which support hotplug? If the answer is "KVM" then the answer is that KVM needs to move to ACPI to get

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 02:24 PM, H. Peter Anvin wrote: > On 11/21/2012 11:19 AM, Sasha Levin wrote: >>> >>> So, are there any mptables platforms which support hotplug? If the >>> answer is "KVM" then the answer is that KVM needs to move to ACPI to get >>> the proper functionality; putting a hack in is

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 11:19 AM, Sasha Levin wrote: >> >> So, are there any mptables platforms which support hotplug? If the >> answer is "KVM" then the answer is that KVM needs to move to ACPI to get >> the proper functionality; putting a hack in is really not okay. > > There are no platforms which

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 01:38 PM, H. Peter Anvin wrote: > On 11/21/2012 10:35 AM, Sasha Levin wrote: >>> >>> Reading between the lines, this sounds like would cause a user-visible >>> difference between mptable platforms and ACPI platforms? If so, that is >>> totally unacceptable. If not, the description

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 10:35 AM, Sasha Levin wrote: >> >> Reading between the lines, this sounds like would cause a user-visible >> difference between mptable platforms and ACPI platforms? If so, that is >> totally unacceptable. If not, the description is confusing. > > With ACPI platforms you don't

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 01:25 PM, H. Peter Anvin wrote: > On 11/21/2012 10:22 AM, Sasha Levin wrote: >> So far CPU hotplug was ignored for mptable implementations which support it >> by >> having the hotpluggable CPUs marked as disabled during boot. >> >> The current kernel code detects that behaviour and

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 10:22 AM, Sasha Levin wrote: > So far CPU hotplug was ignored for mptable implementations which support it by > having the hotpluggable CPUs marked as disabled during boot. > > The current kernel code detects that behaviour and actually deals with it > properly: > > [

[PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
So far CPU hotplug was ignored for mptable implementations which support it by having the hotpluggable CPUs marked as disabled during boot. The current kernel code detects that behaviour and actually deals with it properly: [0.00] Intel MultiProcessor Specification v1.4 [

[PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
So far CPU hotplug was ignored for mptable implementations which support it by having the hotpluggable CPUs marked as disabled during boot. The current kernel code detects that behaviour and actually deals with it properly: [0.00] Intel MultiProcessor Specification v1.4 [

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 10:22 AM, Sasha Levin wrote: So far CPU hotplug was ignored for mptable implementations which support it by having the hotpluggable CPUs marked as disabled during boot. The current kernel code detects that behaviour and actually deals with it properly: [0.00]

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 01:25 PM, H. Peter Anvin wrote: On 11/21/2012 10:22 AM, Sasha Levin wrote: So far CPU hotplug was ignored for mptable implementations which support it by having the hotpluggable CPUs marked as disabled during boot. The current kernel code detects that behaviour and actually

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 10:35 AM, Sasha Levin wrote: Reading between the lines, this sounds like would cause a user-visible difference between mptable platforms and ACPI platforms? If so, that is totally unacceptable. If not, the description is confusing. With ACPI platforms you don't need

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 01:38 PM, H. Peter Anvin wrote: On 11/21/2012 10:35 AM, Sasha Levin wrote: Reading between the lines, this sounds like would cause a user-visible difference between mptable platforms and ACPI platforms? If so, that is totally unacceptable. If not, the description is confusing.

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 11:19 AM, Sasha Levin wrote: So, are there any mptables platforms which support hotplug? If the answer is KVM then the answer is that KVM needs to move to ACPI to get the proper functionality; putting a hack in is really not okay. There are no platforms which support actual

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread Sasha Levin
On 11/21/2012 02:24 PM, H. Peter Anvin wrote: On 11/21/2012 11:19 AM, Sasha Levin wrote: So, are there any mptables platforms which support hotplug? If the answer is KVM then the answer is that KVM needs to move to ACPI to get the proper functionality; putting a hack in is really not okay.

Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

2012-11-21 Thread H. Peter Anvin
On 11/21/2012 11:35 AM, Sasha Levin wrote: On 11/21/2012 02:24 PM, H. Peter Anvin wrote: On 11/21/2012 11:19 AM, Sasha Levin wrote: So, are there any mptables platforms which support hotplug? If the answer is KVM then the answer is that KVM needs to move to ACPI to get the proper